Skip to content

Add Material 3 interactive dartpad samples #101048

Closed
Closed
Add Material 3 interactive dartpad samples#101048
#119716 (+2)
Assignees
TahaTesser
Labels
P3Issues that are less important to the Flutter projectd: api docsIssues with https://api.flutter.dev/frameworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packagesr: fixedIssue is closed as already fixed in a newer version

Description

@guidezpl
guidezpl
opened on Mar 30, 2022

This is a tracking issue for adding interactive code samples (with {@tool dartpad}) to components and widgets which support Material 3.

We should consider leveraging existing existing code samples by either

  • wrapping existing samples with a common widget which shows a toggle to switch the sample to Material 3, at some point, have that be the default (preferred, IMO)
  • copy the simplest existing sample and adding useMaterial3: true

For new Material 3-only widgets, such as NavigationBar, the API doc will only show the Material 3 look.

cc @darrenaustin WDYT?

Components

Other widgets

Activity

  1. guidezpl
    changed the title [-]Add Material 3 interactive code samples[/-] [+]Add Material 3 interactive dartpad samples[/+] on Mar 30, 2022
  2. danagbemava-nc
    added
    in triagePresently being triaged by the triage team
    frameworkflutter/packages/flutter repository. See also f: labels.
    p: material_uimaterial_ui package in flutter/packages
    d: api docsIssues with https://api.flutter.dev/
    documentation
    and removed
    in triagePresently being triaged by the triage team
    on Mar 30, 2022

  3. TahaTesser commented on Mar 30, 2022

    @TahaTesser
    TahaTesser
    on Mar 30, 2022
    Contributor

    @guidezpl @darrenaustin
    If I can help with this, let me know. :)

  4. darrenaustin commented on Mar 31, 2022

    @darrenaustin
    darrenaustin
    on Mar 31, 2022
    Contributor

    This sounds reasonable to me. I have started doing this as I am migrating each component (starting with Card and the still being worked on buttons. But the earlier FAB, NavRail etc, don't yet have M3 examples.

  5. TahaTesser commented on Mar 31, 2022

    @TahaTesser
    TahaTesser
    on Mar 31, 2022
    Contributor

    Hey @guidezpl !

    Working on PRs for FAB and NavRail

  6. guidezpl commented on Mar 31, 2022

    @guidezpl
    guidezpl
    on Mar 31, 2022
    MemberAuthor

    Thanks! Are you able to leverage the existing samples without copying them? @gspencergoog, curious if you have any thoughts on this? Added samples here would be identical, except the bool ThemeData.useMaterial3.

  7. TahaTesser commented on Mar 31, 2022

    @TahaTesser
    TahaTesser
    on Mar 31, 2022
    Contributor

    Thanks! Are you able to leverage the existing samples without copying them? @gspencergoog, curious if you have any thoughts on this? Added samples here would be identical, except the bool ThemeData.useMaterial3.

    Code would be pretty similar but visually it will look quite different and the example description is also pointing to M3 design specs. When useMaterial3 is deprecated, the regular M2 example can be deleted without refactoring the code.

    I'm happy to update PR/Example if the code cannot be identical and I also added FAB variants example and tests for each existing example

  8. guidezpl commented on Mar 31, 2022

    @guidezpl
    guidezpl
    on Mar 31, 2022
    MemberAuthor

    That's a good point, code duplication for the transition period is acceptable

  9. guidezpl
    added this to Material 3on May 23, 2022
  10. guidezpl
    moved this to Todo in Material 3on May 23, 2022
  11. guidezpl
    moved this from Todo to In Progress in Material 3on May 23, 2022
  12. TahaTesser
    self-assigned this
    on Jun 16, 2022
  13. helinanever
    moved this to In progress in Nevercodeon Jul 18, 2022
  14. helinanever
    added this to Nevercodeon Jul 18, 2022

  15. TahaTesser commented on Jul 27, 2022

    @TahaTesser
    TahaTesser
    on Jul 27, 2022
    Contributor

    Working on samples for #107166

  16. Piinks
    added
    P3Issues that are less important to the Flutter project
    on Oct 20, 2022

  17. TahaTesser commented on Feb 27, 2023

    @TahaTesser
    TahaTesser
    on Feb 27, 2023
    Contributor

    @guidezpl
    I'm closing this as done as almost all M3 widgets have examples now.

  18. TahaTesser
    closed this as completedon Feb 27, 2023
  19. github-project-automation
    moved this from In progress to Done (PR merged) in Nevercodeon Feb 27, 2023
  20. github-project-automation
    moved this from 🚧 In Progress to ✅ Done in Material 3on Feb 27, 2023
  21. TahaTesser
    added
    r: fixedIssue is closed as already fixed in a newer version
    on Feb 27, 2023

  22. guidezpl commented on Feb 27, 2023

    @guidezpl
    guidezpl
    on Feb 27, 2023
    MemberAuthor

    Great thank you! Which are missing?

  23. TahaTesser commented on Feb 27, 2023

    @TahaTesser
    TahaTesser
    on Feb 27, 2023 · Hidden as resolved

  24. github-actions commented on Mar 13, 2023

    @github-actions
    github-actionsbot
    on Mar 13, 2023

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  25. github-actions
    locked as resolved and limited conversation to collaborators on Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P3Issues that are less important to the Flutter projectd: api docsIssues with https://api.flutter.dev/frameworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packagesr: fixedIssue is closed as already fixed in a newer version

Type

No type

Projects

  • Nevercode
    Status
    Done (PR merged)

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions