Skip to content

Windows tool_integration_tests_2_6 flakes on deferred_components_test #101609

Description

@keyonghan

(part of #97036)

Two flakes in recent 100 runs.

https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20tool_integration_tests_2_6/845/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20tool_integration_tests_2_6/756/overview

14:25 +37 -1: test\integration.shard\deferred_components_test.dart: simple build appbundle mismatched golden no-validate-deferred-components succeeds [E]                                              
  Expected: <true>
    Actual: <false>
  
  package:test_api                                            expect
  test\integration.shard\deferred_components_test.dart 165:5  main.<fn>

Activity

  1. changed the title [-]Windows tool_integration_tests_1_6 flakes on `deferred_components_test`[/-] [+]Windows tool_integration_tests_2_6 flakes on `deferred_components_test`[/+] on Apr 8, 2022
  2. added
    toolAffects the "flutter" command-line tool. See also t: labels.
    c: flakeTests that sometimes, but not always, incorrectly pass
    on Apr 8, 2022
  3. zanderso commented on Apr 8, 2022

    @zanderso
    Member
  4. christopherfujino commented on Apr 12, 2022

    @christopherfujino
    Contributor

    @GaryQian have you had a chance to take a look at this one?

  5. GaryQian commented on Apr 12, 2022

    @GaryQian
    Contributor

    Not yet, ill look at it today.

  6. christopherfujino commented on Apr 12, 2022

    @christopherfujino
    Contributor

    Not yet, ill look at it today.

    Thanks!

  7. GaryQian commented on Apr 14, 2022

    @GaryQian
    Contributor

    I have so far been unable to repro, and the test seems to have stabilized, remaining green for about 100 runs

    I'll continue to observe its stability.

  8. keyonghan commented on Apr 15, 2022

    @keyonghan
    ContributorAuthor
  9. christopherfujino commented on Apr 26, 2022

    @christopherfujino
    Contributor
  10. christopherfujino commented on May 3, 2022

    @christopherfujino
    Contributor

    @GaryQian were you able to take a look at this one?

  11. GaryQian commented on May 3, 2022

    @GaryQian
    Contributor

    Looking now

  12. christopherfujino commented on May 3, 2022

    @christopherfujino
    Contributor

    Looking now

    Thanks!

  13. GaryQian commented on May 5, 2022

    @GaryQian
    Contributor

    #103161 Adds temporary logging. More info is needed to deflake this.

  14. keyonghan commented on May 6, 2022

    @keyonghan
    ContributorAuthor

    Thanks for working on this!

    Another two same instances:
    https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20tool_integration_tests_2_6/1272/overview
    https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20tool_integration_tests_2_6/1276/overview

    There is another flake on deferred_components_test: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20tool_integration_tests_2_6/1252/overview

    12:15 +35 -1: test\integration.shard\deferred_components_test.dart: simple build appbundle all targets succeeds [E]                                                                                    
      Expected: contains 'app-release.aab'
        Actual: 'Deferred components prebuild validation passed.\n'
                  '\n'
                  ' Building with sound null safety \n'
                  '\n'
                  'Running Gradle task \'bundleRelease\'...                          \n'
                  'Shrinking has been disabled for this build due to deferred components. Shrinking is not available for multi-apk applications. This limitation is expected to be removed when Gradle plugin 4.2+ is available in Flutter.\n'
                  'Running Gradle task \'bundleRelease\'...                             10.6s\n'
                  ''
      
      package:test_api                                           expect
      test\integration.shard\deferred_components_test.dart 75:5  main.<fn>
    
  15. christopherfujino commented on May 10, 2022

    @christopherfujino
    Contributor

    Here's a build that is I believe post Gary's logging change, although I don't see more logging: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20tool_integration_tests_2_6/1276/overview

  16. christopherfujino commented on May 17, 2022

    @christopherfujino
    Contributor

    Here's a build that is I believe post Gary's logging change, although I don't see more logging: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20tool_integration_tests_2_6/1276/overview

    @GaryQian any update on this one?

  17. GaryQian commented on May 25, 2022

    @GaryQian
    Contributor

    Not a solution, but the test has not flaked for ~400+ runs, last failure was https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20tool_integration_tests_2_6/1386/overview on May 11th.

  18. GaryQian commented on May 25, 2022

    @GaryQian
    Contributor

    Even so, the previous failures seem to happen across multiple variants of the test and are quite varied in cause.

  19. christopherfujino commented on May 31, 2022

    @christopherfujino
    Contributor

    In the last 400 commits, I count 1 flakes and 2 failures for this builder, which would be under the threshold.

    @keyonghan am I reading this correctly?

  20. Hixie commented on May 31, 2022

    @Hixie
    Contributor

    I'm going to close this one since we aren't seeing it very much any more, but feel free to reopen if you have any idea what's causing it or if it starts happening more often...

  21. github-actions commented on Jun 15, 2022

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  22. locked as resolved and limited conversation to collaborators on Jun 15, 2022
  23. added
    P0Critical issues such as a build break or regression
    and removed on Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P0Critical issues such as a build break or regressionc: flakeTests that sometimes, but not always, incorrectly passtoolAffects the "flutter" command-line tool. See also t: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions