Skip to content

[CP] dispose ink sparkle #104580

Description

@dnfield

issue_link

#104569

Commit Hash

680a819

Target

stable

Impacted Users

End customers with apps using Material3

Impact Description

The new Ink Sparkle for Material 3 never gets disposed. The more the user interacts with items that cause the ink sparkle to play, the more the application slows down.

This ends up causing severe jank over time that does not go away until app restart.

Workaround

Avoid using material3.

Risk

low

Test Coverage

yes

Validation Steps

Run one of the sample apps in the issues linked to the pull request, make sure it does not slow down when tapping on things that use the ink sparkle.

Activity

  1. dnfield commented on May 25, 2022

    @dnfield
    ContributorAuthor
  2. dnfield commented on May 25, 2022

    @dnfield
    ContributorAuthor
  3. moved this to ✅ Done in Material 3on May 30, 2022
  4. itsjustkevin commented on Jun 10, 2022

    @itsjustkevin
    Contributor

    Flutter 3.0.2

  5. github-actions commented on Jun 24, 2022

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  6. locked as resolved and limited conversation to collaborators on Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    cp: approvedApproved cherry-pick request

    Type

    No type

    Projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions