Skip to content

Windows LUCI postsubmit tests failing on stable #106900

Description

@stuartmorgan-g

Now that go/flutter-build works for flutter/plugins and flutter/packages has support for flutter/plugins and flutter/packages, I noticed that our Windows post-submit tests for stable are all failing, and apparently have been for a long time (forever?). We didn't notice because of LUCI tests not reporting post-submit results to GitHub (I'm not sure why, but that's always been true).

Example:
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20win32-platform_tests%20stable/1669/overview

Every failure is:

fatal: reference is not a tree: <some hash>

I'm not sure why this only affecting stable checkout. Perhaps a recipe error, or a problem with the mirror?

Activity

  1. stuartmorgan-g commented on Jun 30, 2022

    @stuartmorgan-g
    ContributorAuthor
  2. CaseyHillers commented on Jun 30, 2022

    @CaseyHillers
    Contributor

    The Cocoon dashboard is seeing this as well. I think it's related to the Cocoon scheduler triggering immediately when commits are merged to GitHub, but Flutter's policy is to use the GoB mirrors at flutter.googlesource.com/mirrors.

    \cc @yusuf-goog may have been working on something similar, but long term the scheduler needs to move to a poller solution to ensure a commit has been mirrored to GoB before scheduling its LUCI builds.

  3. keyonghan commented on Jul 15, 2022

    @keyonghan
    Contributor

    This is a different issue.

    The flutter/packages is checking out the repo correctly (with mirrored commit ready), but as for refs/heads/stable ref, it is using the same packages commit for the flutter/flutter checkout: https://cs.opensource.google/flutter/recipes/+/main:recipe_modules/repo_util/api.py;l=208

    @stuartmorgan What version of flutter is expected to use for this builder Windows win32-platform_tests stable?

  4. stuartmorgan-g commented on Jul 15, 2022

    @stuartmorgan-g
    ContributorAuthor

    It should be the latest stable of flutter/flutter.

    (At some point I'd like to switch to a pin+roller for stable, like we already did for master, but it hasn't been a priority since out-of-band failures on stable are much rarer.)

  5. keyonghan commented on Jul 15, 2022

    @keyonghan
    Contributor

    (At some point I'd like to switch to a pin+roller for stable, like we already did for master, but it hasn't been a priority since out-of-band failures on stable are much rarer.)

    Considering we want to switch to pin+roller anyway, does it make sense we land this change now? It should fix the issue naturally, but not sure how complex the change would be.
    If not, we can try landing a fix to the recipes, which would be a specific corner patch for this issue.

  6. stuartmorgan-g commented on Jul 16, 2022

    @stuartmorgan-g
    ContributorAuthor

    It's not very complicated; I should be able to get it set up next week.

  7. keyonghan commented on Jul 18, 2022

    @keyonghan
    Contributor

    Thanks @stuartmorgan !

  8. keyonghan commented on Jul 20, 2022

    @keyonghan
    Contributor

    Tree is green for both repos. Thanks for the quick fix @stuartmorgan .

  9. github-actions commented on Aug 3, 2022

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  10. locked as resolved and limited conversation to collaborators on Aug 3, 2022
  11. moved this from Verified to To be archived in [DEPRECATED] Infra Ticket Queueon Jun 26, 2023
  12. added
    P0Critical issues such as a build break or regression
    and removed on Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

P0Critical issues such as a build break or regressionteam-infraOwned by Infrastructure team

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions