Repository navigation
Implement SliverDecoration #107498
Description
The SliverDecoration widget introduced in PR #107269 is not finished and has at least the following issues:
- It doesnt work in horizontal scrollviews
- It uses the paintExtent of the child which isn't always the correct value to use, take for instance this example when applying a rounde corner. The bottom two corners shouldn't be rounded yet.
- Overlap and other advanced properties of slivers aren't accounted for.
- The name is inconsistent with the box counterpart
DecoratedBox, this should be calledDecoratedSliver. The current name suggests its the configuration just likeBoxDecoration
The correct behaviour should be the same as using a SliverStack from sliver_tools with a SliverPositioned.fill behind the second child sliver.
Minimal repro example I can add later if needed (dont have time right now).
Proposed resolution steps
- Revert [framework] SliverDecoration #107269 ✅
- Discuss here what sliver features the finished implementation should and shouldnt support
- Create extensive widget tests for those cases and reimplement
Activity
jonahwilliams commentedon Jul 12, 2022
I think its likely that using the existing Decoration/BoxDecoration API won't work - in this case we'd need a new decoration class that would allow us to communicate the different sliver-y parts of the paint extent so that we could determine correctly where to use rounded corners
Kavantix commentedon Jul 12, 2022
The way I’ve dealt with it so far in SliverStack is to base the size on the
maxPaintExtent. This however might cause painting far outside the visible region.[-]SliverDecoration merged but not finished[/-][+]Implement SliverDecoration[/+]DecoratedSliver (#127823)
github-actions commentedon Jul 5, 2023
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.