Repository navigation
[flutter_tools] general.shard and commands.shard/hermetic are not hermetic #107607
Description
Activity
- changed the title
[-][flutter_tools] tools tests should pass locally[/-][+][flutter_tools] general.shard and commands.shard/hermetic are not hermetic[/+]on Jul 14, 2022 - moved this from Planned Q3 to Planned Q4 in go/flutter-tools-project (deprecated)
on Oct 6, 2022 We should periodically see if any
testUsingContexttests can be migrated totestWithoutContext. One way to do this would be to leverage thedart fixfeature to auto-migrate all testUsingContext invocations to testWithoutContext and then see which tests don't start failing.- moved this from Planned Q4 to Planned Q1 in go/flutter-tools-project (deprecated)
on Mar 2, 2023 - added a commit that references this issue
on Jul 8, 2024
The flutter_tools test suite should pass on local development devices. However, running
dart testin//flutter/packages/flutter_toolswill generally lead to hundreds of failures. Especially the unit test in thegeneral.shardandcommands.shard/hermeticshould be hermetic and not dependent on the environment that they are run in. These tests that pass on CI but fail locally are most likely leaking the environment state, and only coincidentally pass on CI because the environment state is correct. These tests should be updated to fake out the real environment so that the tests are reproducible locally (integration tests will always have dependencies on the system they run on).This is an umbrella tracking issue for PRs that fix individual tests.
As part of this, we should also remove all instances of
@Tags(<string>['no-shuffle'])from the test suite (see #85160)edits by @andrewkolos:
testUsingContextprovide aStdio(withhasTerminalunset) override by default #151357