Skip to content

API to get licenses to show #109

Closed
Closed
API to get licenses to show#109
Assignees
Hixie
Labels
c: new featureNothing broken; request for a new capabilitycustomer: fast (g3)customer: galleryRelating to flutter/gallery repository. Please transfer non-framework issues there.engineflutter/engine related. See also e: labels.frameworkflutter/packages/flutter repository. See also f: labels.waiting for PR to land (fixed)A fix is in flight
Milestone
August

Description

@FlutterIssues
FlutterIssues
opened on Nov 9, 2015

Issue by Hixie
Monday Jul 20, 2015 at 20:33 GMT
Originally opened as https://github.com/flutter/engine/issues/153

From @Hixie on March 2, 2015 21:23

We should have an API that returns all the licenses we're supposed to show in an app's about screen, since the runtime uses some libraries that require notice.

Copied from original issue: domokit/mojo#56

Activity

  1. FlutterIssues
    added
    c: new featureNothing broken; request for a new capability
    on Nov 9, 2015
  2. Hixie
    added
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Nov 20, 2015
  3. Hixie
    added
    engineflutter/engine related. See also e: labels.
    on Dec 5, 2015
  4. Hixie
    added this to the milestone on Dec 5, 2015

  5. Hixie commented on Dec 5, 2015

    @Hixie
    Hixie
    on Dec 5, 2015
    Contributor
    • engine should export a String that contains all the licenses that are relevant to the engine.
    • each library in the framework should do something similar, maybe concatenating its list with the previous layer's list.
    • stocks app should demonstrate how to use this resulting String to show the licenses.

  6. Hixie commented on Jan 18, 2016

    @Hixie
    Hixie
    on Jan 18, 2016
    Contributor

    Maybe the engine should expose a list of licenses it needs to show, and some low level of the framework should have an API that you can add licenses to, and that layer automatically adds the engine's, and other layers can add whatever they need, and then at the widgets layer we can have a widget that shows the licenses along with a "Made with Flutter" stamp.

  7. Hixie
    self-assigned this
    on Jan 25, 2016

  8. Hixie commented on Jan 25, 2016

    @Hixie
    Hixie
    on Jan 25, 2016
    Contributor

    Maybe use gn desk to figure out what files to examine in the first place.

  9. abarth commented on Jan 25, 2016

    @abarth
    abarth
    on Jan 25, 2016
    Contributor

    gn desc

  10. eseidelGoogle
    added
    customer: fast (g3)
    on May 18, 2016

  11. eseidelGoogle commented on May 25, 2016

    @eseidelGoogle
    eseidelGoogle
    on May 25, 2016
    Contributor

    @Hixie is this something we can easily get out of the way (or at least plumb basic support for?) customer:fast would like to check off this checkbox for their launch.

  12. Hixie commented on May 25, 2016

    @Hixie
    Hixie
    on May 25, 2016
    Contributor

    It's on my list after data tables.

  13. sethladd
    added
    customer: galleryRelating to flutter/gallery repository. Please transfer non-framework issues there.
    on May 31, 2016
  14. sethladd
    modified the milestones: Gallery App - Next, on May 31, 2016

  15. 3 remaining items

  16. sethladd
    removed this from the Gallery App - Next milestone on Jun 22, 2016

  17. eseidelGoogle commented on Jul 6, 2016

    @eseidelGoogle
    eseidelGoogle
    on Jul 6, 2016
    Contributor

    Curious if we have any news on this? I know some work has gone in.

  18. Hixie commented on Jul 6, 2016

    @Hixie
    Hixie
    on Jul 6, 2016
    Contributor

    It's ongoing.

  19. sethladd
    modified the milestones: August, Gallery App on Jul 21, 2016
  20. Hixie
    added
    waiting for PR to land (fixed)A fix is in flight
    on Jul 25, 2016

  21. Hixie commented on Jul 26, 2016

    @Hixie
    Hixie
    on Jul 26, 2016
    Contributor

    The bulk of this is now done. Remaining issues are #5052 and #5031 but neither is a blocker to launch.

  22. Hixie
    closed this as completedon Jul 26, 2016
  23. Letty-Liang
    added a commit that references this issue on Mar 21, 2019

    Update dart path post move to 3rd-party (flutter#109)

    fcb277b

  24. github-actions commented on Sep 6, 2021

    @github-actions
    github-actionsbot
    on Sep 6, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  25. github-actions
    locked as resolved and limited conversation to collaborators on Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

c: new featureNothing broken; request for a new capabilitycustomer: fast (g3)customer: galleryRelating to flutter/gallery repository. Please transfer non-framework issues there.engineflutter/engine related. See also e: labels.frameworkflutter/packages/flutter repository. See also f: labels.waiting for PR to land (fixed)A fix is in flight

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions