Skip to content

_DefaultPub.get tries to read version file but does not hold the lock long enough to do so #109205

Closed
#184294
Closed
_DefaultPub.get tries to read version file but does not hold the lock long enough to do so#109205
#184294
Labels
P2Important issues not at the top of the work listc: crashStack traces logged to the consoleteam-toolOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.tool-still-validIssues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.triaged-toolTriaged by Flutter Tool team

Description

@Hixie
Hixie
opened on Aug 9, 2022

_DefaultPub.get has this code:

    final File currentVersion = _fileSystem.file(
      _fileSystem.path.join(Cache.flutterRoot!, 'version'));
    // ...
    if (/*...*?
        lastVersion.readAsStringSync() == currentVersion.readAsStringSync()) {
      // ...

That code has a race condition. If that command runs in parallel with another flutter command, there's no guarantee that the currentVersion file will still be around.

We should not release the lockfile until after this test is done.

cc @christopherfujino @jmagman

Activity

  1. Hixie
    added
    c: crashStack traces logged to the console
    toolAffects the "flutter" command-line tool. See also t: labels.
    P2Important issues not at the top of the work list
    on Aug 9, 2022

  2. christopherfujino commented on Aug 9, 2022

    @christopherfujino
    christopherfujino
    on Aug 9, 2022
    Contributor

    @Hixie thanks for root causing this one!

  3. christopherfujino
    added this to go/flutter-tools-project (deprecated)on Aug 9, 2022
  4. christopherfujino
    moved this to Future bugs/improvements in go/flutter-tools-project (deprecated)on Aug 9, 2022
  5. flutter-triage-bot
    added
    team-toolOwned by Flutter Tool team
    triaged-toolTriaged by Flutter Tool team
    on Jul 8, 2023
  6. matanlurey
    added
    tool-still-validIssues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.
    on Jul 11, 2025
  7. Mr-Pepe
    added 2 commits that reference this issue on Mar 28, 2026

    Hold startup lock through `pub get` to prevent parallel flutter comma…

    ac564a2

    Hold startup lock through `pub get` to prevent parallel flutter comma…

    6d42e9d
  8. github-merge-queue
    added a commit that references this issue on Apr 14, 2026

    Hold startup lock until after `pub get` to prevent races (#184294)

    dd2d719
  9. auto-submit
    closed this as completedin #184294on Apr 14, 2026
  10. master-wayne7
    added a commit that references this issue on Apr 15, 2026

    Hold startup lock until after `pub get` to prevent races (flutter#184294

    f16deab

  11. github-actions commented on Apr 28, 2026

    @github-actions
    github-actionsbot
    on Apr 28, 2026 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  12. github-actions
    locked as resolved and limited conversation to collaborators on Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: crashStack traces logged to the consoleteam-toolOwned by Flutter Tool teamtoolAffects the "flutter" command-line tool. See also t: labels.tool-still-validIssues that have been deemed still valid as part of the Flutter Tools issue cleanup initiative.triaged-toolTriaged by Flutter Tool team

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions