Remove TextSelectionDelegate from SelectableRegionState #111213
Copy link
Copy link
Open
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: text inputEntering text in a text field or keyboard related problemsEntering text in a text field or keyboard related problemsc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.
Description
SelectableRegionState currently mixes in TextSelectionDelegate in order to receive text selection toolbar functionality, however, this functionality is being remove from TextSelectionDelegate in #107193. After the deprecations in that PR are removed, it should be possible to remove TextSelectionDelegate from SelectableRegionState altogether.
Why remove TextSelectionDelegate?
TextSelectionDelegate provides functionality that is related to editing text and which SelectableRegion doesn't use (example). Text selection should be separate from text editing.
CC @chunhtai
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: text inputEntering text in a text field or keyboard related problemsEntering text in a text field or keyboard related problemsc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.
Type
Projects
- StatusShow more project fieldsUpdated
Activity
justinmc commentedon Sep 9, 2022
This should be able to be fixed in #107193 now actually.
Edit: It will need to wait for the deprecations to be removed before this issue can be fully resolved.
justinmc commentedon Oct 5, 2022
I'm going to unassign myself because this is waiting on the deprecations from #107193 to be expire. Once that has happened, I'm happy to open a PR to remove the deprecations and get rid of TextSelectionDelegate in SelectableRegionState.
github-actions commentedon Nov 11, 2022
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.justinmc commentedon Jan 10, 2024
This shouldn't have been closed with #107193.