Skip to content

Remove TextSelectionDelegate from SelectableRegionState #111213

Description

@justinmc

SelectableRegionState currently mixes in TextSelectionDelegate in order to receive text selection toolbar functionality, however, this functionality is being remove from TextSelectionDelegate in #107193. After the deprecations in that PR are removed, it should be possible to remove TextSelectionDelegate from SelectableRegionState altogether.

Why remove TextSelectionDelegate?

TextSelectionDelegate provides functionality that is related to editing text and which SelectableRegion doesn't use (example). Text selection should be separate from text editing.

CC @chunhtai

Activity

  1. added
    a: text inputEntering text in a text field or keyboard related problems
    c: proposalA detailed proposal for a change to Flutter
    on Sep 8, 2022
  2. justinmc commented on Sep 9, 2022

    @justinmc
    ContributorAuthor

    This should be able to be fixed in #107193 now actually.

    Edit: It will need to wait for the deprecations to be removed before this issue can be fully resolved.

  3. self-assigned this
    on Sep 15, 2022
  4. added
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Sep 21, 2022
  5. added
    P2Important issues not at the top of the work list
    on Sep 27, 2022
  6. justinmc commented on Oct 5, 2022

    @justinmc
    ContributorAuthor

    I'm going to unassign myself because this is waiting on the deprecations from #107193 to be expire. Once that has happened, I'm happy to open a PR to remove the deprecations and get rid of TextSelectionDelegate in SelectableRegionState.

  7. removed their assignment
    on Oct 5, 2022
  8. github-actions commented on Nov 11, 2022

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  9. locked as resolved and limited conversation to collaborators on Nov 11, 2022
  10. justinmc commented on Jan 10, 2024

    @justinmc
    ContributorAuthor

    This shouldn't have been closed with #107193.

  11. self-assigned this
    on Jan 10, 2024
  12. unlocked this conversation on Jan 12, 2024
  13. moved this from Incoming Issues to In progress in SelectableRegion Improvementson Mar 2, 2026
  14. moved this from In progress to Incoming Issues in SelectableRegion Improvementson Mar 2, 2026
  15. moved this from Incoming Issues to Updated in SelectableRegion Improvementson Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work lista: text inputEntering text in a text field or keyboard related problemsc: proposalA detailed proposal for a change to Flutterframeworkflutter/packages/flutter repository. See also f: labels.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions