Skip to content

SemanticsActions need to be associated with a view #112207

Closed
#164577
Closed
SemanticsActions need to be associated with a view#112207
#164577
Labels
P3Issues that are less important to the Flutter projecta: multi windowIssues related to multi window supportc: new featureNothing broken; request for a new capabilityengineflutter/engine related. See also e: labels.frameworkflutter/packages/flutter repository. See also f: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Description

@goderbauer
goderbauer
opened on Sep 22, 2022

SemanticsActions dispatched to the framework via the PlatformDispatcher.onSemanticsAction callback need to be associated with a view id in which the node the SemanticsAction needs to be performed on is located in.

Instead of extending the arguments list of onSemanticsAction by yet another argument, I suggest replacing onSemanticsAction with onSemanticsActionEvent which takes a SemanticsActionEvent object containing all arguments currently passed to onSemanticsAction + the view id.

Once the framework has been migrated to onSemanticsActionEvent, onSemanticsAction can be removed.

Activity

  1. goderbauer
    added
    frameworkflutter/packages/flutter repository. See also f: labels.
    engineflutter/engine related. See also e: labels.
    a: multi windowIssues related to multi window support
    on Sep 22, 2022
  2. goderbauer
    added this to Multi Windowon Sep 22, 2022
  3. goderbauer
    moved this to Ready in Multi Windowon Sep 22, 2022
  4. chinmaygarde
    added
    c: new featureNothing broken; request for a new capability
    P3Issues that are less important to the Flutter project
    on Sep 26, 2022

  5. goderbauer commented on Oct 31, 2022

    @goderbauer
    goderbauer
    on Oct 31, 2022
    MemberAuthor

    As a first step, we can introduce the new onSemanticsActionEvent API and SemanticsActionEvent object without adding the view ID to SemanticsActionEvent for now. Should be easy to add this in later.

    @a-wallen Maybe you're interested in this?

  6. a-wallen commented on Oct 31, 2022

    @a-wallen
    a-wallen
    on Oct 31, 2022
    Contributor

    I am interested, but I won't pick this up until I finish #112202.

  7. goderbauer
    closed this as completedon Mar 27, 2023
  8. github-project-automation
    moved this from Ready to Done in Multi Windowon Mar 27, 2023

  9. github-actions commented on Apr 10, 2023

    @github-actions
    github-actionsbot
    on Apr 10, 2023

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  10. github-actions
    locked as resolved and limited conversation to collaborators on Apr 10, 2023
  11. goderbauer
    reopened this on Apr 18, 2023
  12. goderbauer
    moved this from Done to Ready in Multi Windowon Apr 18, 2023
  13. flutter
    unlocked this conversation on Apr 18, 2023
  14. flutter-triage-bot
    added
    multiteam-retriage-candidate
    team-engineOwned by Engine team
    triaged-engineTriaged by Engine team
    on Jul 8, 2023

  15. goderbauer commented on Jul 20, 2023

    @goderbauer
    goderbauer
    on Jul 20, 2023
    MemberAuthor

    The viewID is present in dart:ui now, but it isn't wired up to embedder API.

  16. Hixie
    removed
    multiteam-retriage-candidate
    on Mar 6, 2024

  17. mattkae commented on Mar 4, 2025

    @mattkae
    mattkae
    on Mar 4, 2025
    Contributor

    I am working on wiring this up in the embedder API today.

  18. github-merge-queue
    added a commit that references this issue on Mar 20, 2025

    (#112207) Adding `view_id` parameter to DispatchSemanticsAction and U…

    554c814
  19. mattkae
    closed this as completedin #164577on Mar 20, 2025
  20. github-project-automation
    moved this from Ready to Done in Multi Windowon Mar 20, 2025

  21. github-actions commented on Apr 3, 2025

    @github-actions
    github-actionsbot
    on Apr 3, 2025 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  22. github-actions
    locked as resolved and limited conversation to collaborators on Apr 3, 2025
  23. zhangyuang
    added a commit that references this issue on Jun 9, 2025

    (flutter#112207) Adding `view_id` parameter to DispatchSemanticsActio…

    3f355a6
  24. romanejaquez
    added a commit that references this issue on Aug 14, 2025

    (flutter#112207) Adding `view_id` parameter to DispatchSemanticsActio…

    74d549a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projecta: multi windowIssues related to multi window supportc: new featureNothing broken; request for a new capabilityengineflutter/engine related. See also e: labels.frameworkflutter/packages/flutter repository. See also f: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions