Move updateSemantics from PlatformDispatcher to FlutterView #112221

Activity

1. goderbauer

   added

   frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

   engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.

   a: multi windowIssues related to multi window supportIssues related to multi window support

   on Sep 22, 2022
2. goderbauer

   added this to Multi Windowon Sep 22, 2022
3. goderbauer

   moved this to Ready in Multi Windowon Sep 22, 2022
4. a-wallen

   self-assigned this

   on Sep 26, 2022
5. chinmaygarde

   added

   c: new featureNothing broken; request for a new capabilityNothing broken; request for a new capability

   P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter project

   on Sep 26, 2022
6. a-wallen commented on Oct 6, 2022

   

   a-wallen

   on Oct 6, 2022

   Contributor

   More actions

   @goderbauer what do you think the tests should look like for this?
7. goderbauer commented on Oct 6, 2022

   

   goderbauer

   on Oct 6, 2022

   MemberAuthor

   More actions

   Do we have any tests covering PlatformDispatcher.updateSemantics? Those could be re-purposed, but with calling FlutterView.updateSemantics instead.

   I think ultimately, you want a test to ensure that any information passed to FlutterView.updateSemantics is forwarded properly to the embedder API and invokes the expected callbacks there, e.g. https://github.com/flutter/engine/blob/966f249fb132df0f91d326c022adaa0f8d52dd77/shell/platform/embedder/embedder.h#L1740

   👍React with 👍1Reacted by Alex Wallen
8. a-wallen

   added this to Flutter Desktopon Oct 24, 2022
9. a-wallen

   moved this to In Progress in Flutter Desktopon Oct 24, 2022
10. a-wallen

    moved this from Ready to In Progress in Multi Windowon Oct 24, 2022
11. auto-submit

    closed this as completedin flutter-team-archive/engine#36673on Oct 28, 2022
12. Repository owner moved this from In Progress to Done in Multi Windowon Oct 28, 2022
13. Repository owner moved this from In Progress to Done in Flutter Desktopon Oct 28, 2022
14. a-wallen

    reopened this on Nov 7, 2022
15. a-wallen commented on Nov 7, 2022

    

    a-wallen

    on Nov 7, 2022

    Contributor

    More actions

    Reopening as flutter-team-archive/engine#37388 reverted the issue that closed this.
16. a-wallen commented on Nov 18, 2022

    

    a-wallen

    on Nov 18, 2022

    Contributor

    More actions

    Fixed forward by #114857. Can close now that change is landed.
17. a-wallen

    closed this as completedon Nov 18, 2022
18. github-actions commented on Dec 2, 2022

    

    github-actionsbot

    on Dec 2, 2022

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
19. github-actions

    locked as resolved and limited conversation to collaborators on Dec 2, 2022