Skip to content

[Impeller] Linux_samsung_s10 new_gallery_impeller__transition_perf is over 5% flaky #112438

Closed
Closed
[Impeller] Linux_samsung_s10 new_gallery_impeller__transition_perf is over 5% flaky#112438
Labels
P2Important issues not at the top of the work listc: flakeTests that sometimes, but not always, incorrectly passe: impellerImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Description

@keyonghan
keyonghan
opened on Sep 27, 2022

The task has been flaky 5 out of recent 100 commits: https://data.corp.google.com/sites/dash_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_samsung_s10%20new_gallery_impeller__transition_perf%22&p=LIMIT:100, exceeding threshold 2%.

https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_samsung_s10%20new_gallery_impeller__transition_perf/1348/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_samsung_s10%20new_gallery_impeller__transition_perf/1343/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_samsung_s10%20new_gallery_impeller__transition_perf/1336/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_samsung_s10%20new_gallery_impeller__transition_perf/1312/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_samsung_s10%20new_gallery_impeller__transition_perf/1276/overview

 stdout: [        ] I/SurfaceControl(25155): nativeRelease nativeObject s[-5476376622390413200]
[new_gallery_impeller__transition_perf] [STDOUT] stdout: [        ] I/SurfaceControl(25155): nativeRelease nativeObject e[-5476376622390413200]
[new_gallery_impeller__transition_perf] [STDOUT] stdout: [+1593 ms] 00:00 �[32m+0�[0m: Flutter Gallery transitions (setUpAll)�[0m
[new_gallery_impeller__transition_perf] [STDOUT] stderr: [  +18 ms] VMServiceFlutterDriver: Connecting to Flutter application at http://127.0.0.1:44343/eKRrwlyJjaw=/
[new_gallery_impeller__transition_perf] [STDOUT] stderr: [ +181 ms] VMServiceFlutterDriver: Isolate found with number: 396166288025499
[new_gallery_impeller__transition_perf] [STDOUT] stderr: [  +64 ms] VMServiceFlutterDriver: Isolate is paused at start.
[new_gallery_impeller__transition_perf] [STDOUT] stderr: [        ] VMServiceFlutterDriver: Attempting to resume isolate

[new_gallery_impeller__transition_perf] [STDOUT] stdout: [        ] I/ViewRootImpl@c5a567f[MainActivity](25155): Relayout returned: old=(0,0,1080,2280) new=(0,0,1080,2280) req=(1080,2280)0 dur=6 res=0x1 s={true -5476376618095639248} ch=false fn=2
[new_gallery_impeller__transition_perf] [STDOUT] stdout: [        ] I/ViewRootImpl@c5a567f[MainActivity](25155): updateBoundsLayer: shouldReparent = false t = android.view.SurfaceControl$Transaction@34e8c2d sc = Surface(name=Bounds for - io.flutter.demo.gallery/io.flutter.demo.gallery.MainActivity@0)/@0xef59562 frame = 2
[new_gallery_impeller__transition_perf] [STDOUT] stderr: [  +35 ms] VMServiceFlutterDriver: Connected to Flutter application.

Activity

  1. keyonghan
    changed the title [-]Linux_samsung_s10 new_gallery_impeller__transition_perf[/-] [+]Linux_samsung_s10 new_gallery_impeller__transition_perf is over 5% flaky[/+] on Sep 27, 2022
  2. keyonghan
    assigned
    zanderso
    on Sep 27, 2022
  3. keyonghan
    added
    engineflutter/engine related. See also e: labels.
    P1
    c: flakeTests that sometimes, but not always, incorrectly pass
    on Sep 27, 2022

  4. zanderso commented on Sep 27, 2022

    @zanderso
    zanderso
    on Sep 27, 2022
    Member

    The Engine is crashing. I'm guessing that this is related to Impeller since I'm not aware of the non-Impeller version becoming crash-y recently.

    @keyonghan can you eyeball around which commit this started to happen?

    cc @iskakaushik @chinmaygarde

  5. zanderso
    added
    e: impellerImpeller rendering backend issues and features requests
    on Sep 27, 2022
  6. zanderso
    moved this to 🤔 Needs Triage in Impelleron Sep 27, 2022
  7. zanderso
    added this to Impelleron Sep 27, 2022
  8. zanderso
    moved this from 🤔 Needs Triage to 🐞 Bugs in Impelleron Sep 27, 2022

  9. keyonghan commented on Sep 27, 2022

    @keyonghan
    keyonghan
    on Sep 27, 2022
    ContributorAuthor

    The first flake happened on 463ee3d

  10. jason-simmons commented on Sep 27, 2022

    @jason-simmons
    jason-simmons
    on Sep 27, 2022
    Member

    Symbolized the stack trace from https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8802185536292919905/+/u/run_new_gallery_impeller__transition_perf/test_stdout

    This was a dereference of an invalid command pointer in EncodeCommandsInReactor

    flutter/impeller/renderer/backend/gles/blit_pass_gles.cc:64
third_party/libcxx/include/__functional/function.h:512
flutter/impeller/renderer/backend/gles/reactor_gles.cc:79
flutter/impeller/renderer/backend/gles/render_pass_gles.cc:511
flutter/impeller/renderer/render_pass.cc:74
flutter/impeller/entity/contents/content_context.cc:275
flutter/impeller/entity/contents/filters/gaussian_blur_filter_contents.cc:244
flutter/impeller/entity/contents/filters/filter_contents.cc:304
flutter/impeller/entity/contents/filters/gaussian_blur_filter_contents.cc:102
flutter/impeller/entity/contents/filters/filter_contents.cc:304
flutter/impeller/entity/contents/filters/filter_contents.cc:226
flutter/impeller/entity/entity_pass.cc:471
flutter/impeller/entity/entity_pass.cc:545
flutter/impeller/entity/entity_pass.cc:223
third_party/libcxx/include/__functional/function.h:512
third_party/libcxx/include/__functional/function.h:512
flutter/shell/common/rasterizer.cc:599
flutter/shell/common/rasterizer.cc:379
third_party/libcxx/include/__functional/function.h:512
flutter/shell/common/shell.cc:1172
third_party/libcxx/include/__functional/function.h:1187
flutter/fml/platform/android/message_loop_android.cc:92

  11. zanderso commented on Sep 27, 2022

    @zanderso
    zanderso
    on Sep 27, 2022
    Member

    Routing to @chinmaygarde for triage.

  12. zanderso
    assigned
    chinmaygarde
    and unassigned
    zanderso
    on Sep 27, 2022

  13. 8 remaining items

  14. chinmaygarde
    changed the title [-]Linux_samsung_s10 new_gallery_impeller__transition_perf is over 5% flaky[/-] [+][Impeller] Linux_samsung_s10 new_gallery_impeller__transition_perf is over 5% flaky[/+] on Oct 22, 2022
  15. cbracken
    added a commit that references this issue on Nov 4, 2022

    Mark new_gallery__transition_perf as non-flaky

    82458b2

  16. cbracken commented on Nov 4, 2022

    @cbracken
    cbracken
    on Nov 4, 2022
    Member

    FYI for anyone looking at recent runs of new_gallery_impeller__transition_perf. This test was also flaking due to #114694 which is now fixed, but which would have likely covered up recent incidences of the crash documented in this flake. I've left it marked flaky while it goes bak until this separate issue is fixed.

  17. cbracken
    added a commit that references this issue on Nov 6, 2022

    Mark new_gallery__transition_perf as non-flaky (#114694)

    cf0cd06
  18. shogohida
    added a commit that references this issue on Dec 7, 2022

    Mark new_gallery__transition_perf as non-flaky (flutter#114694)

    3daf48c
  19. gspencergoog
    added a commit that references this issue on Jan 19, 2023

    Mark new_gallery__transition_perf as non-flaky (flutter#114694)

    cb21cb0
  20. flutter-triage-bot
    added
    team-engineOwned by Engine team
    triaged-engineTriaged by Engine team
    on Jul 8, 2023

  21. fluttergithubbot commented on Jul 12, 2023

    @fluttergithubbot
    fluttergithubbot
    on Jul 12, 2023
    Contributor

    [staging pool] flaky ratio for the past (up to) 100 commits between 2023-07-01 and 2023-07-11 is 0.00%. Flaky number: 0; total number: 100.

  22. zanderso commented on Jul 12, 2023

    @zanderso
    zanderso
    on Jul 12, 2023
    Member

    Closing for low flake ratio.

  23. zanderso
    closed this as completedon Jul 12, 2023
  24. github-project-automation
    moved this from 🐞 Bugs to ✅ Done in Impelleron Jul 12, 2023

  25. github-actions commented on Jul 26, 2023

    @github-actions
    github-actionsbot
    on Jul 26, 2023

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  26. github-actions
    locked as resolved and limited conversation to collaborators on Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: flakeTests that sometimes, but not always, incorrectly passe: impellerImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions