[Impeller] Hot reloaded shader code is always SkSL. #114654

Activity

1. bdero

   added

   toolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.

   t: hot reloadReloading code during "flutter run"Reloading code during "flutter run"

   e: impellerImpeller rendering backend issues and features requestsImpeller rendering backend issues and features requests

   on Nov 4, 2022
2. bdero

   added this to Impelleron Nov 4, 2022
3. bdero

   moved this to 🤔 Needs Triage in Impelleron Nov 4, 2022
4. bdero

   changed the title [-]Hot reloaded shader code is always SkSL[/-] [+]Hot reloaded shader code is SkSL when Impeller is enabled[/+] on Nov 4, 2022
5. chinmaygarde

   moved this from 🤔 Needs Triage to 🐞 Bugs in Impelleron Nov 4, 2022
6. chinmaygarde

   changed the title [-]Hot reloaded shader code is SkSL when Impeller is enabled[/-] [+][Impeller] Hot reloaded shader code is always SkSL.[/+] on Nov 4, 2022
7. jonahwilliams commented on Nov 4, 2022

   

   jonahwilliams

   on Nov 4, 2022

   Contributor

   More actions

   Try this:

   diff --git a/packages/flutter_tools/lib/src/build_system/targets/shader_compiler.dart b/packages/flutter_tools/lib/src/build_system/targets/shader_compiler.dart
   index a1721a097c..0d5317d4aa 100644
   --- a/packages/flutter_tools/lib/src/build_system/targets/shader_compiler.dart
   +++ b/packages/flutter_tools/lib/src/build_system/targets/shader_compiler.dart
   @@ -54,7 +54,9 @@ class DevelopmentShaderCompiler {
      void configureCompiler(TargetPlatform? platform, { required bool enableImpeller }) {
        switch (platform) {
          case TargetPlatform.ios:
   -        _shaderTarget = enableImpeller ? ShaderTarget.impelleriOS : ShaderTarget.sksl;
   +        // Always target impeller so both SkSL and platform specific
   +        // shaders are produced.
   +        _shaderTarget = ShaderTarget.impelleriOS;
            break;
          case TargetPlatform.android_arm64:
          case TargetPlatform.android_x64:

   👍React with 👍1Reacted by Brandon DeRosier
8. jonahwilliams commented on Nov 18, 2022

   

   jonahwilliams

   on Nov 18, 2022

   Contributor

   More actions

   I believe this is fixed. Closing
9. jonahwilliams

   closed this as completedon Nov 18, 2022
10. Repository owner moved this from 🐞 Bugs to ✅ Done in Impelleron Nov 18, 2022
11. github-actions commented on Dec 2, 2022

    

    github-actionsbot

    on Dec 2, 2022

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
12. github-actions

    locked as resolved and limited conversation to collaborators on Dec 2, 2022