Repository navigation
Don't use shrink wrap in our samples #116237
Description
Activity
(I removed shrinkWrapping from all of our other samples in #116236, this is the last remaining one.)
- moved this from Todo to Done in Scrolling Performance Pitfalls
on Jul 11, 2023 - added a commit that references this issue
on Jul 11, 2023 This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.- locked as resolved and limited conversation to collaborators
on Jul 25, 2023 - added a commit that references this issue
on Jun 12, 2026
https://github.com/flutter/flutter/blob/fa063eb4ce4140dec9a887c3130239c68f7b713e/examples/api/lib/material/refresh_indicator/refresh_indicator.1.dart uses shrinkWrap, but really it shouldn't. Unfortunately, it is currently hard to achieve this effect without shrinkWrapping. We should implement whatever additional Slivers are needed to not require shrinkWrapping here (e.g. SliverDecoration).