NavigationBar new ripple effect is mis-aligned when using non-default NavigationDestinationLabelBehavior #116751

Activity

1. TahaTesser

   added

   frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

   p: material_uimaterial_ui package in flutter/packagesmaterial_ui package in flutter/packages

   c: regressionIt was better in the past than it is nowIt was better in the past than it is now

   on Dec 8, 2022
2. TahaTesser

   self-assigned this

   on Dec 8, 2022
3. TahaTesser

   added this to Nevercodeon Dec 8, 2022
4. TahaTesser

   moved this to To do in Nevercodeon Dec 8, 2022
5. TahaTesser

   moved this from To do to In progress in Nevercodeon Dec 8, 2022
6. TahaTesser commented on Dec 8, 2022

   

   TahaTesser

   on Dec 8, 2022

   Last edited by TahaTesser

   ContributorAuthor

   More actions

   Note:
   NavigationRail new ripple doesn't have this issue as it addressed all types of label behaviors.
   I will fix it ASAP and add an ink ripple test for non-default label behavior due to this regression.
7. TahaTesser commented on Dec 8, 2022

   

   TahaTesser

   on Dec 8, 2022

   ContributorAuthor

   More actions

   cc: @HansMuller
8. HansMuller commented on Dec 9, 2022

   

   HansMuller

   on Dec 9, 2022

   Contributor

   More actions

   I guess this got past us in #115499. Thanks in advance for the fix and especially for the additional regression tests.

   👍React with 👍1Reacted by Taha Tesser
9. TahaTesser

   moved this from In progress to PR submitted in Nevercodeon Dec 12, 2022
10. auto-submit

    closed this as completedin #116888on Dec 12, 2022
11. Repository owner moved this from PR submitted to Done (PR merged) in Nevercodeon Dec 12, 2022
12. github-actions commented on Mar 5, 2023

    

    github-actionsbot

    on Mar 5, 2023

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
13. github-actions

    locked as resolved and limited conversation to collaborators on Mar 5, 2023