Skip to content

Remove hard-coded devicePixelRatio from paintImage #117477

Closed
#118721
Closed
Remove hard-coded devicePixelRatio from paintImage#117477
#118721
Assignees
goderbauer
Labels
P1High-priority issues at the top of the work lista: imagesLoading, displaying, rendering imagesframeworkflutter/packages/flutter repository. See also f: labels.

Description

@goderbauer
goderbauer
opened on Dec 21, 2022

paintImage currently hard-codes the device pixel ratio by reaching out to the window singleton:

flutter/packages/flutter/lib/src/painting/decoration_image.dart

Lines 565 to 567 in d1244b7

// It's ok to use this instead of a MediaQuery because if this changes,
// whatever is aware of the MediaQuery will be repainting the image anyway.
displaySize: outputSize * PaintingBinding.instance.window.devicePixelRatio,

In a multi-viewed world, this will not work anymore because paintImage has no idea what view the image is getting painted on. This will need to be refactored to get the devicePixelRatio passed in.

Activity

  1. goderbauer
    added
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Dec 21, 2022
  2. goderbauer
    added this to Multi Windowon Dec 21, 2022
  3. goderbauer
    added
    a: imagesLoading, displaying, rendering images
    on Dec 21, 2022
  4. goderbauer
    moved this to Ready in Multi Windowon Dec 21, 2022

  5. goderbauer commented on Dec 21, 2022

    @goderbauer
    goderbauer
    on Dec 21, 2022
    MemberAuthor

    The device pixel ratio here is only used for the oversized image debug check within paintImage.

  6. goderbauer
    self-assigned this
    on Jan 3, 2023
  7. goderbauer
    added
    P1High-priority issues at the top of the work list
    on Jan 3, 2023
  8. auto-submit
    closed this as completedin #118721on Jan 18, 2023
  9. github-project-automation
    moved this from Ready to Done in Multi Windowon Jan 18, 2023

  10. github-actions commented on Mar 4, 2023

    @github-actions
    github-actionsbot
    on Mar 4, 2023

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  11. github-actions
    locked as resolved and limited conversation to collaborators on Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work lista: imagesLoading, displaying, rendering imagesframeworkflutter/packages/flutter repository. See also f: labels.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions