Skip to content

[CP] NavigationBar ink ripple fixes #119554

Closed
Closed
[CP] NavigationBar ink ripple fixes#119554
Assignees
XilaiZhang
Labels
cp: approvedApproved cherry-pick requestcp: merge-to-stableCherry-picks that should be merged to stablecp: reviewCherry-picks in the review queue

Description

@Piinks
Piinks
opened on Jan 30, 2023

issue_link

#117420

Commit Hash

74645b4

Target

stable

pr_link

#119553

Impacted Users

All M3 users

Impact Description

This fixes an issue with ink ripple alignment with the navigation bar when using Material 3.

In order to pick this commit, another previously cherry pick needed to be included: #117500

Workaround

No.

Risk

low

Test Coverage

yes

Validation Steps

The runnable example on https://master-api.flutter.dev/flutter/material/NavigationBar-class.html shows the issue, with this fix it no longer reproduces.

Activity

  1. Piinks
    added
    cp: reviewCherry-picks in the review queue
    on Jan 30, 2023

  2. CaseyHillers commented on Jan 30, 2023

    @CaseyHillers
    CaseyHillers
    on Jan 30, 2023
    Contributor

    @HansMuller can you review this CP request?

  3. HansMuller commented on Jan 30, 2023

    @HansMuller
    HansMuller
    on Jan 30, 2023
    Contributor

    LGTM

  4. CaseyHillers
    added
    cp: approvedApproved cherry-pick request
    on Jan 30, 2023
  5. CaseyHillers
    assigned
    XilaiZhang
    on Jan 30, 2023
  6. CaseyHillers
    added
    cp: merge-to-stableCherry-picks that should be merged to stable
    on Feb 6, 2023
  7. guidezpl
    added this to Material 3on Feb 7, 2023
  8. godofredoc
    closed this as completedon Feb 7, 2023
  9. github-project-automation
    moved this to ✅ Done in Material 3on Feb 7, 2023

  10. github-actions commented on Mar 3, 2023

    @github-actions
    github-actionsbot
    on Mar 3, 2023

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  11. github-actions
    locked as resolved and limited conversation to collaborators on Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

cp: approvedApproved cherry-pick requestcp: merge-to-stableCherry-picks that should be merged to stablecp: reviewCherry-picks in the review queue

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions