Skip to content

[CP] NavigationDrawer scrolling and safe area support #119556

Closed

Description

@Piinks

issue_link

#116782

Commit Hash

9a347fb

Target

stable

pr_link

#119555

Impacted Users

Any users of the material NavigationDrawer

Impact Description

This new widget did not account for safe area or overflow. The associated change added support for both so the contents of the drawer will not overflow or be obscured by screen notches and the like.

Workaround

Kind of, but not completely. Users that may engage their own workarounds could find themselves broken by the true fix later on if it is delayed.

Risk

low

Test Coverage

yes

Validation Steps

The code sample from #116782 shows overflowing items in the drawer, running the sample with this change allows for them to scroll into view.

Activity

  1. CaseyHillers commented on Jan 30, 2023

    @CaseyHillers
    Contributor

    @HansMuller can you review this CP request?

  2. HansMuller commented on Jan 30, 2023

    @HansMuller
    Contributor

    LGTM

  3. github-actions commented on Mar 3, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  4. locked as resolved and limited conversation to collaborators on Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

cp: approvedApproved cherry-pick requestcp: reviewCherry-picks in the review queue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions