Skip to content

Support safe area and scrolling in the NavigationDrawer (#116995) - #119555

Merged
XilaiZhang merged 3 commits into
flutter:flutter-3.7-candidate.1from
Piinks:pickDrawerFix
Feb 1, 2023
Merged

XilaiZhang merged 3 commits into
flutter:flutter-3.7-candidate.1from
Piinks:pickDrawerFix

Conversation

@Piinks

@Piinks Piinks commented Jan 30, 2023 •

Copy link
Copy Markdown
Contributor

CP for #119556

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

* Update navigation_drawer.dart

* Update navigation_drawer_test.dart

* Update navigation_drawer_test.dart

* update tests

* Update navigation_drawer_test.dart

* Update navigation_drawer_test.dart
@flutter-dashboard flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Jan 30, 2023

@TahaTesser TahaTesser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XilaiZhang
XilaiZhang merged commit c96f14a into flutter:flutter-3.7-candidate.1 Feb 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 2, 2023
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Feb 2, 2023
* 7999584 [release] use current branch as opposed to master (flutter/flutter#119648)

* 9271eeb Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (flutter/flutter#118963)

* c96f14a Support safe area and scrolling in the NavigationDrawer (#116995) (flutter/flutter#119555)

* ff6e9d4 CP: Throw error when plural case had undefined behavior (#116622) (flutter/flutter#119384)

* 7048ed9 Update Engine revision to 800594f1f4a6674010a6f1603c07a919b4d7ebd7 for stable release 3.7.1 (flutter/flutter#119687)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 3, 2023
stuartmorgan-g pushed a commit to flutter-team-archive/plugins that referenced this pull request Feb 3, 2023
…#7091)

* 7999584b9 [release] use current branch as opposed to master (flutter/flutter#119648)

* 9271eeba1 Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (flutter/flutter#118963)

* c96f14ad3 Support safe area and scrolling in the NavigationDrawer (#116995) (flutter/flutter#119555)

* ff6e9d4fa CP: Throw error when plural case had undefined behavior (#116622) (flutter/flutter#119384)

* 7048ed95a Update Engine revision to 800594f1f4a6674010a6f1603c07a919b4d7ebd7 for stable release 3.7.1 (flutter/flutter#119687)
waegari pushed a commit to waegari/flutter_plugins that referenced this pull request Jul 3, 2025
…flutter-team-archive#7091)

* 7999584b9 [release] use current branch as opposed to master (flutter/flutter#119648)

* 9271eeba1 Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (flutter/flutter#118963)

* c96f14ad3 Support safe area and scrolling in the NavigationDrawer (#116995) (flutter/flutter#119555)

* ff6e9d4fa CP: Throw error when plural case had undefined behavior (#116622) (flutter/flutter#119384)

* 7048ed95a Update Engine revision to 800594f1f4a6674010a6f1603c07a919b4d7ebd7 for stable release 3.7.1 (flutter/flutter#119687)
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…3143)

* 7999584 [release] use current branch as opposed to master (flutter/flutter#119648)

* 9271eeb Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (flutter/flutter#118963)

* c96f14a Support safe area and scrolling in the NavigationDrawer (#116995) (flutter/flutter#119555)

* ff6e9d4 CP: Throw error when plural case had undefined behavior (#116622) (flutter/flutter#119384)

* 7048ed9 Update Engine revision to 800594f1f4a6674010a6f1603c07a919b4d7ebd7 for stable release 3.7.1 (flutter/flutter#119687)
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
…3143)

* 7999584 [release] use current branch as opposed to master (flutter/flutter#119648)

* 9271eeb Switching over from iOS-15 to iOS-16 in .ci.yaml. (#118807) (flutter/flutter#118963)

* c96f14a Support safe area and scrolling in the NavigationDrawer (#116995) (flutter/flutter#119555)

* ff6e9d4 CP: Throw error when plural case had undefined behavior (#116622) (flutter/flutter#119384)

* 7048ed9 Update Engine revision to 800594f1f4a6674010a6f1603c07a919b4d7ebd7 for stable release 3.7.1 (flutter/flutter#119687)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants