[gen-l10n] Failed to complete the generation when FLUTTER_STORAGE_BASE_URL is overridden

The issue is breaking every user that is using localizations and a custom `FLUTTER_STORAGE_BASE_URL`.

This also happens with flutter pub get if the l10n generation is synthetic.

The tool will report Found syntax errors but not any actual syntax errors.

Related issues:

When run flutter gallery loaclly, faced with exception with Syntax Error when try to pub get. #117610
flutter gen-i10n throws Found syntax errors. after upgrading to 3.7.0 (mostly affecting china mirror) #119435
Flutter 3.7.0 Cause Localization Bug #119585

Root cause

When FLUTTER_STORAGE_BASE_URL is being overridden, the cache getter will try to raise an error to STDERR that the user is using a custom storage base.

flutter/packages/flutter_tools/lib/src/cache.dart

Lines 523 to 526 in 5b6572f

    
           _logger.printError( 
        
             'Flutter assets will be downloaded from $overrideUrl. Make sure you trust this source!', 
        
             emphasis: true, 
        
           );

But using an error print will cause the generate tool recognized as an exception.

flutter/packages/flutter_tools/lib/src/localizations/gen_l10n.dart

Lines 1249 to 1252 in 5b6572f

    
           // If there were any syntax errors, don't write to files. 
        
           if (logger.hadErrorOutput) { 
        
             throw L10nException('Found syntax errors.'); 
        
           }

And when it's using synthetic package, flutter pub get will also raise exceptions.

flutter/packages/flutter_tools/lib/src/dart/generate_synthetic_packages.dart

Lines 61 to 67 in 5b6572f

    
           if (result.hasException) { 
        
             throwToolExit( 
        
               'Generating synthetic localizations package failed with ${result.exceptions.length} ${pluralize('error', result.exceptions.length)}:' 
        
               '\n\n' 
        
               '${result.exceptions.values.map<Object?>((ExceptionMeasurement e) => e.exception).join('\n\n')}', 
        
             ); 
        
           }

Steps to Reproduce

Run export FLUTTER_STORAGE_BASE_URL=https://storage.flutter-io.cn in the terminal.
flutter create test_l10n
Setup internationalization for the project according to the doc.
flutter pub get or flutter gen-l10n

flutter doctor -v

Flutter assets will be downloaded from https://storage.flutter-io.cn. Make sure you trust this source!

[!] Flutter (Channel stable, 3.7.0, on Microsoft Windows [版本 10.0.22000.1455], locale zh-CN)
    • Flutter version 3.7.0 on channel stable at X:\SDK\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b06b8b2710 (7 days ago), 2023-01-23 16:55:55 -0800
    • Engine revision b24591ed32
    • Dart version 2.19.0
    • DevTools version 2.20.1
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

@thkim1011

cc @thkim1011 I'm going to submit a quick fix to use a warning instead of an error for the storage override.

Workaround steps:

Change the below line to printWarning.

flutter/packages/flutter_tools/lib/src/cache.dart

Line 523 in 5b6572f

_logger.printError(
Delete flutter_tools.snapshot and flutter_tools.stamp under the ${path_to_flutter_sdk}/bin/cache.
Rerun any Flutter commands.

Similar issue: #119435

Workaround steps:

Change the below line to printWarning.

flutter/packages/flutter_tools/lib/src/cache.dart

Line 523 in 5b6572f

_logger.printError(

Delete flutter_tools.snapshot and flutter_tools.stamp under the ${path_to_flutter_sdk}/bin/cache.

Rerun any Flutter commands.

It is worked!

Working on a fix right now.

@thkim1011

@thkim1011 thanks so much for the quick fix! Could you also request a cherrypick to the stable channel via the issue template?

@thkim1011

@thkim1011 thanks so much for the quick fix! Could you also request a cherrypick to the stable channel via the issue template?

#119678

@thkim1011

@thkim1011 thanks so much for the quick fix! Could you also request a cherrypick to the stable channel via the issue template?

#119678

Thanks!

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

Navigation Menu

Repository navigation

[gen-l10n] Failed to complete the generation when `FLUTTER_STORAGE_BASE_URL` is overridden #119593

The issue is breaking every user that is using localizations and a custom `FLUTTER_STORAGE_BASE_URL`.

Root cause

Steps to Reproduce

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	_logger.printError(
	'Flutter assets will be downloaded from $overrideUrl. Make sure you trust this source!',
	emphasis: true,
	);

	// If there were any syntax errors, don't write to files.
	if (logger.hadErrorOutput) {
	throw L10nException('Found syntax errors.');
	}

	if (result.hasException) {
	throwToolExit(
	'Generating synthetic localizations package failed with ${result.exceptions.length} ${pluralize('error', result.exceptions.length)}:'
	'\n\n'
	'${result.exceptions.values.map<Object?>((ExceptionMeasurement e) => e.exception).join('\n\n')}',
	);
	}

[gen-l10n] Failed to complete the generation when FLUTTER_STORAGE_BASE_URL is overridden #119593

Description

The issue is breaking every user that is using localizations and a custom FLUTTER_STORAGE_BASE_URL.

Root cause

Steps to Reproduce

Activity

AlexV525 commented on Jan 31, 2023

AlexV525 commented on Jan 31, 2023

darshankawar commented on Jan 31, 2023

conghaonet commented on Jan 31, 2023

thkim1011 commented on Jan 31, 2023

christopherfujino commented on Feb 1, 2023

AlexV525 commented on Feb 2, 2023

christopherfujino commented on Feb 2, 2023

github-actions commented on Mar 3, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

[gen-l10n] Failed to complete the generation when `FLUTTER_STORAGE_BASE_URL` is overridden #119593

The issue is breaking every user that is using localizations and a custom `FLUTTER_STORAGE_BASE_URL`.