Skip to content

[CP] Make gen-l10n error handling independent of logger state #119678

Closed
Closed
[CP] Make gen-l10n error handling independent of logger state#119678
Assignees
godofredoc
Labels
cp: approvedApproved cherry-pick requestcp: merge-to-stableCherry-picks that should be merged to stablecp: reviewCherry-picks in the review queue

Description

@AlexV525
AlexV525
opened on Feb 1, 2023

issue_link

#119593

Commit Hash

3884381

Target

stable

pr_link

#119679

Impacted Users

Users that are using any overridden FLUTTER_STORAGE_BASE_URL

Impact Description

The issue is breaking every user that is using localizations and a custom FLUTTER_STORAGE_BASE_URL. The gen-l10n tool will report Found syntax errors but not any actual syntax errors.

Workaround

#119593 (comment) or CP #119644.

Risk

low

Test Coverage

yes

Validation Steps

Follow the steps to reproduce in #119593 (comment).

Activity

  1. AlexV525
    added
    cp: reviewCherry-picks in the review queue
    on Feb 1, 2023

  2. AlexV525 commented on Feb 2, 2023

    @AlexV525
    AlexV525
    on Feb 2, 2023
    MemberAuthor

    cc @christopherfujino @thkim1011

  3. christopherfujino commented on Feb 2, 2023

    @christopherfujino
    christopherfujino
    on Feb 2, 2023
    Contributor

    This CP LGTM

  4. itsjustkevin
    added
    cp: approvedApproved cherry-pick request
    cp: merge-to-stableCherry-picks that should be merged to stable
    on Feb 3, 2023
  5. itsjustkevin
    assigned
    godofredoc
    on Feb 3, 2023
  6. godofredoc
    closed this as completedon Feb 4, 2023

  7. github-actions commented on Mar 3, 2023

    @github-actions
    github-actionsbot
    on Mar 3, 2023

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  8. github-actions
    locked as resolved and limited conversation to collaborators on Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

cp: approvedApproved cherry-pick requestcp: merge-to-stableCherry-picks that should be merged to stablecp: reviewCherry-picks in the review queue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions