Skip to content

Bug in ListTileThemeData.copyWith() introduced in https://github.com/flutter/flutter/pull/117965 #119734

Closed
#119738
Closed
Bug in ListTileThemeData.copyWith() introduced in https://github.com/flutter/flutter/pull/117965#119734
#119738
Assignees
TahaTesser
Labels
c: regressionIt was better in the past than it is nowcustomer: googleVarious Google teamsframeworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packagesr: fixedIssue is closed as already fixed in a newer version

Description

@math1man
math1man
opened on Feb 1, 2023

#117965 introduced a bug in ListTileThemeData.copyWith().

The code has these lines

titleTextStyle: titleTextStyle ?? this.titleTextStyle,
subtitleTextStyle: titleTextStyle ?? this.subtitleTextStyle,
leadingAndTrailingTextStyle: titleTextStyle ?? this.leadingAndTrailingTextStyle,

Note that titleTextStyle is assigned to each value. The correct code should be

titleTextStyle: titleTextStyle ?? this.titleTextStyle,
subtitleTextStyle: subtitleTextStyle ?? this.subtitleTextStyle,
leadingAndTrailingTextStyle: leadingAndTrailingTextStyle ?? this.leadingAndTrailingTextStyle,

Activity

  1. ChristianEdwardPadilla
    added
    customer: googleVarious Google teams
    on Feb 1, 2023
  2. TahaTesser
    self-assigned this
    on Feb 1, 2023
  3. TahaTesser
    added
    frameworkflutter/packages/flutter repository. See also f: labels.
    p: material_uimaterial_ui package in flutter/packages
    on Feb 1, 2023
  4. TahaTesser
    added this to Nevercodeon Feb 1, 2023
  5. github-project-automation
    moved this to To do in Nevercodeon Feb 1, 2023
  6. TahaTesser
    added
    c: regressionIt was better in the past than it is now
    on Feb 1, 2023
  7. TahaTesser
    moved this from To do to PR submitted in Nevercodeon Feb 1, 2023
  8. auto-submit
    closed this as completedin #119738on Feb 1, 2023
  9. github-project-automation
    moved this from PR submitted to Done (PR merged) in Nevercodeon Feb 1, 2023
  10. TahaTesser
    added
    r: fixedIssue is closed as already fixed in a newer version
    on Feb 1, 2023

  11. github-actions commented on Mar 3, 2023

    @github-actions
    github-actionsbot
    on Mar 3, 2023

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  12. github-actions
    locked as resolved and limited conversation to collaborators on Mar 3, 2023
  13. ChristianEdwardPadilla
    reopened this on Aug 28, 2023
  14. github-project-automation
    moved this from Done (PR merged) to In progress in Nevercodeon Aug 28, 2023
  15. ChristianEdwardPadilla
    closed this as completedon Aug 28, 2023
  16. github-project-automation
    moved this from In progress to Done (PR merged) in Nevercodeon Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

c: regressionIt was better in the past than it is nowcustomer: googleVarious Google teamsframeworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packagesr: fixedIssue is closed as already fixed in a newer version

Type

No type

Projects

  • Nevercode
    Status
    Done (PR merged)

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions