Skip to content

iPhone X: Additional horizontal inset for list view content in horizontal layouts #12101

Closed

Description

@cbracken

Steps to Reproduce

On the iPhone X, List views in horizontal mode should include additional horizontal padding on either side to avoid drawing list content under the sensor housing notch.

See Apple's Human Interface Guidelines for iPhone X.

Dependent on issue #12098

Example from Flutter Gallery:
screen shot 2017-09-12 at 15 14 58

Flutter Doctor

[✓] Flutter (on Mac OS X 10.12.6 16G29, locale en-AU, channel master)
    • Flutter at /Users/cbracken/src/flutter/flutter
    • Framework revision dd7e313317 (51 minutes ago), 2017-09-14 12:28:21 -0700
    • Engine revision 57a1445a45
    • Tools Dart version 1.25.0-dev.11.0

[✓] Android toolchain - develop for Android devices (Android SDK 25.0.3)
    • Android SDK at /Users/cbracken/Library/Android/sdk
    • Platform android-25, build-tools 25.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_112-release-b06)

[✓] iOS toolchain - develop for iOS devices (Xcode 9.0)
    • Xcode at /Applications/Xcode9.0.app/Contents/Developer
    • Xcode 9.0, Build version 9A235
    • ios-deploy 1.9.2
    • CocoaPods version 1.3.1

Activity

  1. added
    frameworkflutter/packages/flutter repository. See also f: labels.
    platform-iosiOS applications specifically
    on Sep 14, 2017
  2. changed the title [-]iPhone X [/-] [+]iPhone X: Additional horizontal inset for list/grid view content[/+] on Sep 14, 2017
  3. changed the title [-]iPhone X: Additional horizontal inset for list/grid view content[/-] [+]iPhone X: Additional horizontal inset for list/grid view content in horizontal layouts[/+] on Sep 14, 2017
  4. Hixie commented on Sep 14, 2017

    @Hixie
    Contributor

    This isn't about list views. The same is true for any content.

    We should probably just have the Scaffold automatically indent its body appropriately (using MediaQuery.of(padding), and updating the padding on the inside accordingly, see #12084), with a parameter to override that in case you want something else to take care of it.

  5. cbracken commented on Sep 14, 2017

    @cbracken
    MemberAuthor

    It's not strictly about any content -- e.g. much full-screen content such as images should not be inset, but it's definitely more general than list/grid views.

  6. added this to the 3: Current Milestone milestone on Sep 15, 2017
  7. self-assigned this
    on Oct 31, 2017
  8. changed the title [-]iPhone X: Additional horizontal inset for list/grid view content in horizontal layouts[/-] [+]iPhone X: Additional horizontal inset for list view content in horizontal layouts[/+] on Dec 14, 2017
  9. cbracken commented on Dec 14, 2017

    @cbracken
    MemberAuthor

    ListTile and the gallery home screen done in #13545.

  10. github-actions commented on Sep 4, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  11. locked as resolved and limited conversation to collaborators on Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

frameworkflutter/packages/flutter repository. See also f: labels.platform-iosiOS applications specifically

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions