Repository navigation
[go_router_builder] Iterable parameters don't support default values #122003
Description
Steps to Reproduce
- Execute
flutter pub run build_runner build --delete-conflicting-outputson the code sample (see "Code sample" section below) - The default value for the
Iterableparameter is not copied and there are errors in the generated code (see "Logs" section below)
Expected results:
Default parameters should be supported on all the supported types (aka Iterable)
Actual results:
Iterable parameters don't support default values
Code sample
Or you can check out https://github.com/ValentinVignal/flutter_app_stable/tree/go-router-builder/default-value-with-iterable-parameters
import 'package:flutter/material.dart';
import 'package:go_router/go_router.dart';
part 'main.g.dart';
@TypedGoRoute<MyRoute>(path: '/')
class MyRoute extends GoRouteData {
const MyRoute({
this.iterable = const [],
});
final Iterable<int> iterable;
@override
Widget build(BuildContext context, GoRouterState state) =>
const Placeholder();
}which generates
// GENERATED CODE - DO NOT MODIFY BY HAND
part of 'main.dart';
// **************************************************************************
// GoRouterGenerator
// **************************************************************************
List<GoRoute> get $appRoutes => [
$myRoute,
];
GoRoute get $myRoute => GoRouteData.$route(
path: '/',
factory: $MyRouteExtension._fromState,
);
extension $MyRouteExtension on MyRoute {
static MyRoute _fromState(GoRouterState state) => MyRoute(
iterable: state.queryParametersAll['iterable']?.map(int.parse), // <- The argument type 'Iterable<int>?' can't be assigned to the parameter type 'Iterable<int>'
);
String get location => GoRouteData.$location(
'/',
queryParams: {
if (iterable != const [])
'iterable': iterable?.map((e) => e.toString()).toList(), // <- The receiver can't be null, so the null-aware operator '?.' is unnecessary.
Try replacing the operator '?.' with '.'
},
);
void go(BuildContext context) => context.go(location);
void push(BuildContext context) => context.push(location);
void pushReplacement(BuildContext context) =>
context.pushReplacement(location);
}
Logs
No log
Analyzing flutter_app_stable...
error • The argument type 'Iterable<int>?' can't be assigned to the parameter type 'Iterable<int>' • lib/main.g.dart:20:19 • argument_type_not_assignable
info • Equality operator `==` invocation with references of unrelated types • lib/main.g.dart:26:15 • unrelated_type_equality_checks
warning • The receiver can't be null, so the null-aware operator '?.' is unnecessary • lib/main.g.dart:27:33 • invalid_null_aware_operator
3 issues found. (ran in 4.1s)
Activity
danagbemava-nc commentedon Mar 6, 2023
Reproducible using the code sample and the steps outlined above.
flutter doctor -v
github-actions commentedon Mar 31, 2023
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.