Mac module_test is 2.06% flaky #125108

Activity

1. fluttergithubbot

   added

   P1

   c: flakeTests that sometimes, but not always, incorrectly passTests that sometimes, but not always, incorrectly pass

   team: flakes

   toolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.

   on Apr 19, 2023
2. fluttergithubbot

   assigned

   zanderso

   on Apr 19, 2023
3. zanderso commented on Apr 20, 2023

   

   zanderso

   on Apr 20, 2023

   Member

   More actions

   12334 is a transient gradle network failure:

   [2023-04-12 09:10:27.312459] [STDOUT] stderr: Exception in thread "main" javax.net.ssl.SSLHandshakeException: Remote host terminated the handshake
   

   I think we already have code in the tool or devicelab scripts to catch errors like this and do a retry here: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/android/gradle_errors.dart#L219.

   Not sure that's the path we're on, but that code is looking for the string javax.net.ssl.SSLHandshakeException: Remote host closed connection during handshake, which is slightly different.

   Maybe the new message needs to be added to the list the tool is matching on?

   cc @christopherfujino for tool triage
   FYI-only @reidbaker
4. zanderso

   removed their assignment

   on Apr 20, 2023
5. zanderso

   added

   P1High-priority issues at the top of the work listHigh-priority issues at the top of the work list

   and removed

   P1

   on Apr 20, 2023
6. christopherfujino

   self-assigned this

   on Apr 21, 2023
7. christopherfujino commented on Apr 21, 2023

   

   christopherfujino

   on Apr 21, 2023

   Contributor

   More actions

   12334 is a transient gradle network failure:

   [2023-04-12 09:10:27.312459] [STDOUT] stderr: Exception in thread "main" javax.net.ssl.SSLHandshakeException: Remote host terminated the handshake
   

   I think we already have code in the tool or devicelab scripts to catch errors like this and do a retry here: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/android/gradle_errors.dart#L219.

   Not sure that's the path we're on, but that code is looking for the string javax.net.ssl.SSLHandshakeException: Remote host closed connection during handshake, which is slightly different.

   Maybe the new message needs to be added to the list the tool is matching on?

   cc @christopherfujino for tool triage FYI-only reidbaker

   Good catch, will do
8. auto-submit

   added a commit that references this issue on Apr 21, 2023

   add gradle error handler for when the remote ssl host terminates hand…

   ...

   1561b65
9. fluttergithubbot commented on Apr 26, 2023

   

   fluttergithubbot

   on Apr 26, 2023

   ContributorAuthor

   More actions

   [prod pool] current flaky ratio for the past (up to) 100 commits is 1.02%. Flaky number: 1; total number: 98.
   One recent flaky example for a same commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20module_test/12464
   Commit: ea34f7d
   Flaky builds:
   https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20module_test/12464

   Recent test runs:
   https://flutter-dashboard.appspot.com/#/build?taskFilter=Mac%20module_test
10. zanderso commented on Apr 26, 2023

    

    zanderso

    on Apr 26, 2023

    Member

    More actions

    12464 has gradle errors that I haven't seen before:

    [2023-04-19 14:14:21.504034] [STDOUT] stderr: > Could not resolve all files for configuration ':flutter:releaseRuntimeClasspath'.
    [2023-04-19 14:14:21.504678] [STDOUT] stderr:    > Failed to transform core-1.6.0.aar (androidx.core:core:1.6.0) to match attributes {artifactType=android-classes-jar, org.gradle.category=library, org.gradle.dependency.bundling=external, org.gradle.libraryelements=aar, org.gradle.status=release, org.gradle.usage=java-runtime}.
    [2023-04-19 14:14:21.504738] [STDOUT] stderr:       > Execution failed for AarToClassTransform: /Volumes/Work/s/w/ir/cache/gradle/caches/modules-2/files-2.1/androidx.core/core/1.6.0/10775f024a338475a5e374033f4532a7b3d8994f/core-1.6.0.aar.
    [2023-04-19 14:14:21.504757] [STDOUT] stderr:          > invalid entry CRC (expected 0x37242907 but got 0x1487064a)
    

    @reidbaker do you know what those mean?
11. reidbaker commented on Apr 26, 2023

    

    reidbaker

    on Apr 26, 2023

    Contributor

    More actions

    https://stackoverflow.com/questions/54671736/why-does-the-flutter-build-failed-with-the-error-could-not-resolve-all-files-for

    might be related to a more recent effort to explicitly set java source compatibility but my gut is this is a clean/rebuild issue that should go away on its own.
    flutter/packages#3825 as an example.
12. fluttergithubbot commented on May 3, 2023

    

    fluttergithubbot

    on May 3, 2023

    ContributorAuthor

    More actions

    [prod pool] current flaky ratio for the past (up to) 100 commits is 0.00%. Flaky number: 0; total number: 95.
13. reidbaker

    closed this as completedon May 3, 2023
14. github-actions commented on May 17, 2023

    

    github-actionsbot

    on May 17, 2023

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
15. github-actions

    locked as resolved and limited conversation to collaborators on May 17, 2023