You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[packages] Test with old AGP/Gradle in flutter/packages CI #125689
In general we want to keep our example apps updated to recent versions of AGP and Gradle:
Ensures compatibility with recent versions of AGP/Gradle that many users will be using
Ensures compatibility with recent related toolchains (e.g., the latest version of Android Studio doesn't easily work with AGP 4.1)
In some cases, avoids hard-to-understand errors when updating dependencies
However, the downside is that we aren't testing with old versions of AGP; #125621 and #125482 are examples of recent cases where we broke people using old versions of AGP with changes that were fine on current versions. Ideally we should have testing in CI that builds all of our Android plugins in a project that uses the oldest version of AGP that flutter supports.
Currently my thought is to add options to the build-all-packages repo tooling command that let us set the AGP and Gradle versions, and run it a second time on Android. (Alternately we could replace the current version with this, since we test with recent tooling in the individual examples, but it's only a five-minute build or so, so duplicating it shouldn't be a big deal.)
I would love if tooling got the Lowest version of agp from a constant in packages/flutter_tools/lib/src/android/gradle_utils.dart. That is where I expect any tooling enforcement would get the value as well.
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
Activity
stuartmorgan-g commentedon Apr 28, 2023
Currently my thought is to add options to the
build-all-packagesrepo tooling command that let us set the AGP and Gradle versions, and run it a second time on Android. (Alternately we could replace the current version with this, since we test with recent tooling in the individual examples, but it's only a five-minute build or so, so duplicating it shouldn't be a big deal.)reidbaker commentedon Apr 28, 2023
I would love if tooling got the Lowest version of agp from a constant in packages/flutter_tools/lib/src/android/gradle_utils.dart. That is where I expect any tooling enforcement would get the value as well.
stuartmorgan-g commentedon May 15, 2023
The lack of this just bit us again in #126710; we used an AGP 7.0 property without realizing it.
[ci] Add a legacy Android build-all test (#4005)
github-actions commentedon Jun 5, 2023
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.[ci] Add a legacy Android build-all test (flutter#4005)
[ci] Add a legacy Android build-all test (flutter#4005)