Skip to content

Sky packages should be able to write unit tests that depend on Sky #126

Closed
Closed
Sky packages should be able to write unit tests that depend on Sky#126
Assignees
abarth
Labels
a: tests"flutter test", flutter_test, or one of our tests

Description

@FlutterIssues
FlutterIssues
opened on Nov 9, 2015

Issue by collinjackson
Wednesday Aug 12, 2015 at 21:03 GMT
Originally opened as https://github.com/flutter/engine/issues/580

jackson-macpro:playfair jackson$ dart --version
Dart VM version: 1.11.0-dev.3.0 (Thu May 28 03:42:12 2015) on "macos_x64"

jackson-macpro:playfair jackson$ pub run test test/playfair_test.dart
Wrong script snapshot version, expected '146df3da808a6da22679d25262d18cfb' found '6ab2a2a1aedc6faea804a9c1850edf4b'
00:00 +0 -1: loading test/playfair_test.dart
Failed to load "test/playfair_test.dart":
The built-in library 'dart:sky' is not available on the stand-alone VM.
'package:playfair/playfair.dart': error: line 7 pos 1: library handler failed
import 'dart:sky' as sky;
^
00:00 +0 -1: Some tests failed.

If we included the Sky shell executable in the Sky package we could run these tests.

Activity

  1. FlutterIssues
    added
    affects: dev experience
    a: tests"flutter test", flutter_test, or one of our tests
    on Nov 9, 2015

  2. FlutterIssues commented on Nov 9, 2015

    @FlutterIssues
    FlutterIssues
    on Nov 9, 2015
    Author

    Comment by eseidelGoogle
    Wednesday Aug 12, 2015 at 21:54 GMT

    Discussed this with @abarth. There are several problems to solve here.

    1. We do not build Mac binaries for releases, currently. We need a Mac VM in the cloud (maybe http://www.macincloud.com/ ?) to do so.
    2. Once we build Mac binaries, we don't yet upload them to google storage (like we do linux and android-arm: https://github.com/domokit/sky_engine/blob/master/sky/tools/big_red_button.py#L63), but we could once we build them on every revision.
    3. Even once we have those binaries, we need to sky_shell to exit at the right time for Dart's test_runner to understand. See https://github.com/domokit/sky_engine/issues/581.
  3. abarth
    self-assigned this
    on Nov 10, 2015

  4. abarth commented on Nov 18, 2015

    @abarth
    abarth
    on Nov 18, 2015
    Contributor

    Duplicate of #307

  5. abarth
    closed this as completedon Nov 18, 2015
  6. Letty-Liang
    added a commit that references this issue on Mar 21, 2019

    Enable -Wunguaraded-availability for iOS builds (flutter#126)

    dc349db

  7. github-actions commented on Sep 7, 2021

    @github-actions
    github-actionsbot
    on Sep 7, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  8. github-actions
    locked as resolved and limited conversation to collaborators on Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

a: tests"flutter test", flutter_test, or one of our tests

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions