Skip to content

Add tests for Material 3 Date pickers #126826

Description

@TahaTesser

Is there an existing issue for this?

Steps to reproduce

While working on some other M3 date picker issues like #126597, I noticed the M3 layout and config changes made in #119033 aren't tested in date_picker_test.dart.

https://github.com/flutter/flutter/pull/119033/files#diff-198d5dd0fe89bb71e1940816baf20e7b57ee896ed31120b7c3fcebcc4ac3bfbe has a bunch of changes in date_picker.dart and most of these changes aren't tested in date_picker_test.dart.

Screenshot 2023-05-15 at 17 18 32

Expected results

date_picker_test.dart has M3 test coverage

Actual results

Most of the M3 changes aren't tested and modifying some M3 defaults or removing M3-related widgets from date_picker.test doesn't fail tests in the date_picker_test.dart class.
Screenshot 2023-05-15 at 17 28 13

Code sample

~

Screenshots or Video

Screenshots / Video demonstration

[Upload media here]

Logs

Logs
[Paste your logs here]

Flutter Doctor output

Doctor output
[Paste your output here]

Activity

  1. added
    a: tests"flutter test", flutter_test, or one of our tests
    frameworkflutter/packages/flutter repository. See also f: labels.
    p: material_uimaterial_ui package in flutter/packages
    on May 15, 2023
  2. self-assigned this
    on May 15, 2023
  3. moved this from To do to Done (PR merged) in Nevercodeon May 23, 2023
  4. moved this from Done (PR merged) to In progress in Nevercodeon May 23, 2023
  5. moved this from ✅ Done to 🚧 In Progress in Material 3on May 23, 2023
  6. TahaTesser commented on May 23, 2023

    @TahaTesser
    ContributorAuthor

    Date range picker tests are pending

  7. moved this from In progress to PR submitted in Nevercodeon May 26, 2023
  8. moved this from 🚧 In Progress to ✅ Done in Material 3on May 26, 2023
  9. moved this from PR submitted to Done (PR merged) in Nevercodeon May 26, 2023
  10. github-actions commented on Jun 9, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  11. locked as resolved and limited conversation to collaborators on Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

a: tests"flutter test", flutter_test, or one of our testsf: date/time pickerDate or time picker widgetsframeworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packages

Type

No type

Projects

  • Status
    Done (PR merged)

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions