Skip to content

Column header icons not displaying in cocoon #127038

Closed
Closed
Column header icons not displaying in cocoon#127038
Labels
P2Important issues not at the top of the work listteam-infraOwned by Infrastructure team

Description

@zanderso
zanderso
opened on May 17, 2023

Not sure when this started or if the change is intentional, but I find the headers useful.

Screenshot 2023-05-17 at 9 32 45 AM

Activity

  1. zanderso
    added
    team-infraOwned by Infrastructure team
    on May 17, 2023

  2. ricardoamador commented on May 17, 2023

    @ricardoamador
    ricardoamador
    on May 17, 2023
    Contributor

    cc @andrewkolos Can you please take a look at this?
    Error being returned:
    image

  3. ricardoamador commented on May 17, 2023

    @ricardoamador
    ricardoamador
    on May 17, 2023
    Contributor

    From the cocoon log:

    logMessage: "Null check operator used on a null value
#0      StaticFileHandler.get (package:cocoon_service/src/request_handling/static_file_handler.dart:53:39)
#1      RequestHandler.service.<anonymous closure> (package:cocoon_service/src/request_handling/request_handler.dart:50:30)
#2      _rootRun (dart:async/zone.dart:1399:13)
#3      _CustomZone.run (dart:async/zone.dart:1301:19)
#4      _runZoned (dart:async/zone.dart:1804:10)
#5      runZoned (dart:async/zone.dart:1747:10)
#6      RequestHandler.service (package:cocoon_service/src/request_handling/request_handler.dart:42:12)
#7      main.<anonymous closure>.<anonymous closure> (file:///app/bin/server.dart:318:61)
#8      runAppEngine.<anonymous closure> (package:appengine/appengine.dart:80:12)
#9      runAppEngine.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:appengine/src/appengine_internal.dart:57:18)
#10     _ServiceScope._fork.<anonymous closure> (package:gcloud/service_scope.dart:205:19)
#11     _rootRun (dart:async/zone.dart:1399:13)
#12     _CustomZone.run (dart:async/zone.dart:1301:19)
#13     _runZoned (dart:async/zone.dart:1804:10)
#14     runZonedGuarded (dart:async/zone.dart:1792:12)
#15     runZoned (dart:async/zone.dart:1744:12)
#16     _ServiceScope._fork (package:gcloud/service_scope.dart:204:12)
#17     fork (package:gcloud/service_scope.dart:102:30)
#18     runAppEngine.<anonymous closure>.<anonymous closure> (package:appengine/src/appengine_internal.dart:55:12)
#19     AppEngineHttpServer.run.<anonymous closure>.<anonymous closure> (package:appengine/src/server/server.dart:83:17)
#20     _rootRunUnary (dart:async/zone.dart:1407:47)
#21     _CustomZone.runUnary (dart:async/zone.dart:1308:19)
#22     _CustomZone.runUnaryGuarded (dart:async/zone.dart:1217:7)
#23     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)
#24     _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271:7)
#25     _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:776:19)
#26     _StreamController._add (dart:async/stream_controller.dart:650:7)
#27     _StreamController.add (dart:async/stream_controller.dart:598:5)
#28     _HttpServer._handleRequest (dart:_http/http_impl.dart:3326:19)
#29     new _HttpConnection.<anonymous closure> (dart:_http/http_impl.dart:3110:19)
#30     _rootRunUnary (dart:async/zone.dart:1407:47)
#31     _CustomZone.runUnary (dart:async/zone.dart:1308:19)
#32     _CustomZone.runUnaryGuarded (dart:async/zone.dart:1217:7)
#33     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)
#34     _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271:7)
#35     _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:776:19)
#36     _StreamController._add (dart:async/stream_controller.dart:650:7)
#37     _StreamController.add (dart:async/stream_controller.dart:598:5)
#38     _HttpParser._headersEnd (dart:_http/http_parser.dart:389:19)
#39     _HttpParser._doParse (dart:_http/http_parser.dart:745:15)
#40     _HttpParser._parse (dart:_http/http_parser.dart:319:7)
#41     _rootRunUnary (dart:async/zone.dart:1407:47)
#42     _CustomZone.runUnary (dart:async/zone.dart:1308:19)
#43     _CustomZone.runUnaryGuarded (dart:async/zone.dart:1217:7)
#44     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)
#45     _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271:7)
#46     _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:776:19)
#47     _StreamController._add (dart:async/stream_controller.dart:650:7)
#48     _StreamController.add (dart:async/stream_controller.dart:598:5)
#49     _Socket._onData (dart:io-patch/socket_patch.dart:2368:41)
#50     _rootRunUnary (dart:async/zone.dart:1415:13)
#51     _CustomZone.runUnary (dart:async/zone.dart:1308:19)
#52     _CustomZone.runUnaryGuarded (dart:async/zone.dart:1217:7)
#53     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)
#54     _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271:7)
#55     _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:776:19)
#56     _StreamController._add (dart:async/stream_controller.dart:650:7)
#57     _StreamController.add (dart:async/stream_controller.dart:598:5)
#58     new _RawSocket.<anonymous closure> (dart:io-patch/socket_patch.dart:1886:33)
#59     _NativeSocket.issueReadEvent.issue (dart:io-patch/socket_patch.dart:1343:14)
#60     _microtaskLoop (dart:async/schedule_microtask.dart:40:21)
#61     _startMicrotaskLoop (dart:async/schedule_microtask.dart:49:5)
#62     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:123:13)
#63     _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:190:5)
"

  4. andrewkolos commented on May 17, 2023

    @andrewkolos
    andrewkolos
    on May 17, 2023
    Contributor

    I'm sorry I'm just seeing this. This is possibly related to/caused by #126077. I wonder if some reference wasn't updated. I'm also curious why some icons are displaying while others aren't.

  5. ricardoamador commented on May 17, 2023

    @ricardoamador
    ricardoamador
    on May 17, 2023
    Contributor

    Would there need to be an update somewhere in cocoon?

  6. ricardoamador commented on May 17, 2023

    @ricardoamador
    ricardoamador
    on May 17, 2023
    Contributor

    It looks like there is a stale reference in our main.dart.js file:

    A.aHl(q.ajG("AssetManifest.bin",A.aOi(),t.jo).bD(new A.ZR(r,this,a,q),s),new A.ZS(r),s,t.K)

  7. ricardoamador commented on May 17, 2023

    @ricardoamador
    ricardoamador
    on May 17, 2023
    Contributor

    I would guess this is coming from the build of the flutter dashboard app so I am looking to see if I can find where this is coming from. These are wild guesses so please @andrewkolos correct me if I am wrong here.

  8. ricardoamador commented on May 17, 2023

    @ricardoamador
    ricardoamador
    on May 17, 2023
    Contributor

    Okay this is the issue. I was able to build the dashboard locally and the change references your new AssetManifest.smcbin file.

  9. ricardoamador commented on May 17, 2023

    @ricardoamador
    ricardoamador
    on May 17, 2023
    Contributor

    The AssetManifest.smcbin is getting used now with the newest version of flutter but the error is persisting. Still looking...

  10. ricardoamador
    added this to [DEPRECATED] Infra Ticket Queueon May 17, 2023
  11. github-project-automation
    moved this to New in [DEPRECATED] Infra Ticket Queueon May 17, 2023
  12. ricardoamador
    moved this from New to In progress in [DEPRECATED] Infra Ticket Queueon May 17, 2023
  13. ricardoamador
    added
    P2Important issues not at the top of the work list
    passed secondary triage
    on May 17, 2023

  14. ricardoamador commented on May 17, 2023

    @ricardoamador
    ricardoamador
    on May 17, 2023
    Contributor

    Adding to our queue since this is customer facing and is causing frequent 500 errors in the logs causing alerts to fire.

  15. ricardoamador commented on May 18, 2023

    @ricardoamador
    ricardoamador
    on May 18, 2023
    Contributor

    Okay found the issue during our triage meeting. Since this is a made up format, we needed to actually map the mimetype to binary so that we could serve this file type. I changed it to map it to 'application/octet-stream' which is the same as binary. Will have a PR shortly.

    image

  16. auto-submit
    added a commit that references this issue on May 18, 2023

    Add the mimetype for smcbin file extension (#2776)

    2bfdbe9
  17. ricardoamador
    moved this from In progress to Fixed in [DEPRECATED] Infra Ticket Queueon May 18, 2023
  18. ricardoamador
    moved this from Fixed to Verified in [DEPRECATED] Infra Ticket Queueon May 22, 2023
  19. ricardoamador
    closed this as completedon May 23, 2023
  20. github-project-automation
    moved this from Verified to Fixed in [DEPRECATED] Infra Ticket Queueon May 23, 2023
  21. keyonghan
    moved this from Fixed to Verified in [DEPRECATED] Infra Ticket Queueon May 30, 2023

  22. github-actions commented on Jun 6, 2023

    @github-actions
    github-actionsbot
    on Jun 6, 2023

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  23. github-actions
    locked as resolved and limited conversation to collaborators on Jun 6, 2023
  24. keyonghan
    moved this from Verified to To be archived in [DEPRECATED] Infra Ticket Queueon Jan 31, 2024
  25. keyonghan
    moved this from To be archived to Verified in [DEPRECATED] Infra Ticket Queueon Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listteam-infraOwned by Infrastructure team

    Type

    No type

    Projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions