Repository navigation
[CP] Add namespace to module build file templates #128136
Description
Activity
@reidbaker for review.
@reidbaker for review.
On vacation for 2 weeks you will need another reviewer
Reacted by Kevin ChisholmHandoff to @gmackall and @stuartmorgan for review.
Is this missing a link to the cherry-pick pr? The pr_link points to the pr to master
Is this missing a link to the cherry-pick pr? The pr_link points to to the pr to master
Oh, @CaseyHillers do I need to open another PR to stable?
Yes, CP authors need to send the CP PR as well. Otherwise, we don't have the ability to assess the risk it has on the branch.
Reacted by Camille Simon@CaseyHillers @Jasguerrero I think this is ready for another look!
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.- locked as resolved and limited conversation to collaborators
on Jun 29, 2023
issue_link
#126403
Commit Hash
31a665c
Target
stable
pr_link
#126963#128360
Changelog Description
Adds
namespaceconfiguration to modulebuild.gradlefile templates that is required when using >= Gradle 8.0.Impacted Users
Flutter devs using add-to-app on Android wanting to use Gradle 8.0+
Impact Description
Flutter developers generating Flutter modules to use for android-add-to-app with an Android app using Gradle 8.0+ will receive a vague error describing an issue with
namespacein itsbuild.gradleconfiguration files as described in #126403 (comment).Workaround
A developer may work around the issue by adding the
namespaceconfiguration manually to the module'sbuild.gradleconfiguration files.Risk
low
Test Coverage
yes
Validation Steps
Once you checkout my fix, you need to find an existing Android app or create one to use for testing. Modify it if necessary to use Gradle 8.0+. Then, create a Flutter module to add to an existing Android app using the command listed here. Finally, try running the app or building the apk and verify that it is successful.