Additional color mappings for FAB in Material 3 #130702

Activity

1. gawi151

   changed the title [-]Additional color mappings for FAB button in Material 3[/-] [+]Additional color mappings for FAB in Material 3[/+] on Jul 17, 2023
2. TahaTesser

   added

   in triagePresently being triaged by the triage teamPresently being triaged by the triage team

   c: new featureNothing broken; request for a new capabilityNothing broken; request for a new capability

   frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

   p: material_uimaterial_ui package in flutter/packagesmaterial_ui package in flutter/packages

   c: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutter

   team-designOwned by Design Languages teamOwned by Design Languages team

   and removed

   in triagePresently being triaged by the triage teamPresently being triaged by the triage team

   on Jul 17, 2023
3. TahaTesser

   added this to Material 3on Jul 17, 2023
4. rydmike commented on Jul 17, 2023

   

   rydmike

   on Jul 17, 2023

   Contributor

   More actions

   While it is certainly in the M3 spec, I am not sure having variant FloatingActionButton constructors just for different color mappings is strictly necessary.

   Flutter already supports alternative color mapping on FAB Widget property level and global theme level, so the M3 design options can easily be made.

   That said I have nothing against having FloatingActionButton.surface(), FloatingActionButton.secondary() and FloatingActionButton.tertiary() available as named constructor options.

   They would then need to be either fixed color mapping wise to those colors (not affected by FAB Theme color properties and not have widget color properties) since their variant name already fully describes its colors or not be destroyed when using FAB theming, like variants are today.

   Currently, the already existing FloatingActionButton size variants are destroyed if you FAB theme their shape border radius or icons size. Since FAB theme only supports one variant, see #107946.

   Alternatively, this could also be a documentation topic, "How to make FABs using M3 guide variant color mappings" or something like that.
5. HansMuller commented on Jul 19, 2023

   

   HansMuller

   on Jul 19, 2023

   Contributor

   More actions

   @rydmike - agree that this is probably best served by an example. Any interest in providing one?
6. MaxYablochkin commented on Jul 27, 2023

   

   MaxYablochkin

   on Jul 27, 2023

   Last edited by HansMuller

   More actions

   I don't see the point in additional constructors FloatingActionButton.surface() FloatingActionButton.secondary() FloatingActionButton.tertiary() when you can change the background & foreground in style

   👍React with 👍2Reacted by Max Yablochkin and Rydmike
7. HansMuller

   added

   P2Important issues not at the top of the work listImportant issues not at the top of the work list

   triaged-designTriaged by Design Languages teamTriaged by Design Languages team

   on Jul 27, 2023
8. TahaTesser

   added

   d: examplesSample code and demosSample code and demos

   on Aug 21, 2023
9. 4 remaining items

   Load more
10. TahaTesser

    added this to Nevercodeon Aug 28, 2023
11. TahaTesser

    moved this from 🗺 Planned to 🚧 In Progress in Material 3on Aug 28, 2023
12. TahaTesser

    moved this from To do to In progress in Nevercodeon Aug 28, 2023
13. github-project-automation

    moved this to To do in Nevercodeon Aug 28, 2023
14. TahaTesser

    moved this from 🚧 In Progress to ✅ Done in Material 3on Aug 28, 2023
15. TahaTesser

    moved this from ✅ Done to 🚧 In Progress in Material 3on Aug 28, 2023
16. TahaTesser

    moved this from In progress to PR submitted in Nevercodeon Aug 28, 2023
17. auto-submit

    closed this as completedin #133453on Aug 29, 2023
18. github-project-automation

    moved this from 🚧 In Progress to ✅ Done in Material 3on Aug 29, 2023
19. github-project-automation

    moved this from PR submitted to Done (PR merged) in Nevercodeon Aug 29, 2023
20. auto-submit

    added a commit that references this issue on Aug 29, 2023

    Add FAB Additional Color Mappings example (#133453)

    ...

    d8d7e01
21. TahaTesser

    added

    r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer version

    on Aug 29, 2023
22. github-actions commented on Sep 12, 2023

    

    github-actionsbot

    on Sep 12, 2023

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
23. github-actions

    locked as resolved and limited conversation to collaborators on Sep 12, 2023