Repository navigation
Flutter tool should require "--local-engine-host" when "--local-engine" is set #132245
Description
Activity
@christopherfujino Two quick questions:
- Where, if anywhere, should we announce this change? I don't think it's important enough to be an "announcement", so maybe just
#hackers-engineand#hackers-tool(and respective internal-only chat groups)? This is mostly just to make sure we get feedback if we're missing some nuance. - If I wanted to test "what if this was required", is the best way to make it a
throwToolExitand create a draft PR?
- Where, if anywhere, should we announce this change? I don't think it's important enough to be an "announcement", so maybe just
- notifying those discord channels SGTM, I'd just add that you should update: https://github.com/flutter/flutter/wiki/The-flutter-tool#using-a-locally-built-engine-with-the-flutter-tool. That's where I point people when they ask how to do it.
- That would test most of the framework tests (most devicelab tests don't run pre-submit, but I doubt any of them are using a local engine). @godofredoc do you know if there are any existing engine tests that use
flutter --local-engine? Also, per Add--local-engine-host, which if specified, is used instead of being inferred #132180 (comment), it sounds like we may break golem?
- I'd just add that you should update: https://github.com/flutter/flutter/wiki/The-flutter-tool#using-a-locally-built-engine-with-the-flutter-tool
Want to informally review this delta before I apply it?
https://gist.github.com/matanlurey/ddb5e16e349c5bbdd0c1e036f189aed4- It sounds like we may break golem?
I'll follow-up with Bill's team and make sure they have ample time (or can show me where to make changes).
For posterity, we communicated the tooling changes via Discord:
Reacted by Christopher Fujino- I'd just add that you should update: https://github.com/flutter/flutter/wiki/The-flutter-tool#using-a-locally-built-engine-with-the-flutter-tool
Want to informally review this delta before I apply it? https://gist.github.com/matanlurey/ddb5e16e349c5bbdd0c1e036f189aed4
- It sounds like we may break golem?
I'll follow-up with Bill's team and make sure they have ample time (or can show me where to make changes).
wiki diff LGTM
- changed the title
[-]Flutter tool should require "--local-host-engine" when "--local-engine" is set[/-][+]Flutter tool should require "--local-engine-host" when "--local-engine" is set[/+]on Aug 10, 2023 23 remaining items
Looking good so far. Will try finalizing this next week after it has baked a bit.
- added a commit that references this issue
on Aug 22, 2023 So with this change when I want to run. the app on macOS with local engine I always need to run it with
--local-engine=host_debug_unopt --local-engine-host=host_debug_unopt? Seems rather redundant.This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.- locked as resolved and limited conversation to collaborators
on Sep 14, 2023
Status: WIP. There are enough PRs out right now where I'm focusing on getting them landed/sticking before moving forward.
This is a follow-up to #132180 (comment).
As of #132180,
--local-engine-hostis optional, and if omitted, falls back to trying to derive the host.We'd like to make this explicit instead, so:
devicelab.dev/devicelab/**to provide--local-engine-host. #132342glfwexamples and related examples inexamples/*gl*/**.examples/**to provide--local-engine-host. flutter-team-archive/engine#44610tool_backend.dartand related scripts influtter_tools/bin/*.flutter_tools/bin/*.(dart|sh)to provide, if set, --local-engine-host. #132336flutter.groovyand related.flutter_toolsinternals related to Gradle/XCode to set--local-engine-host. #132346dart_roll_helper.py.dart_roller_helper.pyto explicitly pass--local-engine-hostto thefluttertool. flutter-team-archive/buildroot#751web_ui/dev/build.dartand related files inweb_ui/dev/*.web_ui/**to explicitly pass--local-engine-hostto thefluttertool. flutter-team-archive/engine#44613Updateflutter_gbd.dev/bots/test.dart.dev/bots/test.dart(and friends) to provide--local-engine-host. #132354build_linux.dart.xcode_build_settings.dart.build_windows.dart.--local-engine-hostis required, and fix CI bots, tests, and bash scripts that aren't using itthrowToolExitand delete_getHostEngineBasenameand friends