Skip to content

Update dev/devicelab/** to provide --local-engine-host. - #132342

Merged
matanlurey merged 4 commits into
flutter:masterfrom
matanlurey:tool-local-engine-host-devicelab
Aug 11, 2023
Merged

Update dev/devicelab/** to provide --local-engine-host.#132342
matanlurey merged 4 commits into
flutter:masterfrom
matanlurey:tool-local-engine-host-devicelab

Conversation

@matanlurey

@matanlurey matanlurey commented Aug 10, 2023

Copy link
Copy Markdown
Contributor

Partial work towards #132245.

I have to admit I don't totally understand what I've updated, or whether there are more integration points needed.

@matanlurey
matanlurey marked this pull request as ready for review August 10, 2023 22:10
@matanlurey matanlurey mentioned this pull request Aug 10, 2023
Closed
13 tasks done
gaaclarke
gaaclarke reviewed Aug 10, 2023
View reviewed changes

@gaaclarke gaaclarke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good to me. I'm not certain how good the test coverage is for this code in pre-submit checks. You may have to launch your own post-submit instances of a devicelab test to get a sanity check before landing. The instructions for running these tests locally uses the devicelab/bin/test_runner.dart, not devicelab/bin/run.dart so I don't think you can verify it locally. @zanderso may know better.

Comment thread dev/devicelab/bin/run.dart Outdated
@matanlurey
matanlurey force-pushed the tool-local-engine-host-devicelab branch from 7dcce3f to cca72e3 Compare August 10, 2023 22:49
gaaclarke
gaaclarke approved these changes Aug 10, 2023
View reviewed changes
Comment thread dev/devicelab/bin/run.dart Outdated
@matanlurey
matanlurey removed the request for review from zanderso August 11, 2023 00:25
@matanlurey
matanlurey merged commit a7997f6 into flutter:master Aug 11, 2023
@matanlurey
matanlurey deleted the tool-local-engine-host-devicelab branch August 11, 2023 00:25
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 11, 2023
@engine-flutter-autoroll
a7997f6 Update dev/devicelab/** to provide --local-engine-host. (f…
5d96a85 
…lutter/flutter#132342)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 11, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 11, 2023
@engine-flutter-autoroll
a7997f6 Update dev/devicelab/** to provide --local-engine-host. (f…
caaab84 
…lutter/flutter#132342)
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Aug 11, 2023
@engine-flutter-autoroll
Roll Flutter from 685141b to 9b6945b (25 revisions) (#4680)
ec83969 
flutter/flutter@685141b...9b6945b

2023-08-11 [email protected] Roll Flutter Engine from 93e8901490e7 to 77dfeea40e10 (1 revision) (flutter/flutter#132389)
2023-08-11 [email protected] Roll Flutter Engine from 4e532b957225 to 93e8901490e7 (1 revision) (flutter/flutter#132381)
2023-08-11 [email protected] Roll Flutter Engine from 25afdb9b696d to 4e532b957225 (4 revisions) (flutter/flutter#132376)
2023-08-11 [email protected] Roll Flutter Engine from da23fb0d9a1d to 25afdb9b696d (1 revision) (flutter/flutter#132370)
2023-08-11 [email protected] Roll Flutter Engine from acd1bc5536ef to da23fb0d9a1d (2 revisions) (flutter/flutter#132367)
2023-08-11 [email protected] Roll Flutter Engine from 578a8e8aabf6 to acd1bc5536ef (1 revision) (flutter/flutter#132365)
2023-08-11 [email protected] Roll Flutter Engine from 18a71c031f5f to 578a8e8aabf6 (1 revision) (flutter/flutter#132364)
2023-08-11 [email protected] Update `dev/devicelab/**` to provide `--local-engine-host`. (flutter/flutter#132342)
2023-08-10 [email protected] Roll Flutter Engine from b019ac62f21f to 18a71c031f5f (2 revisions) (flutter/flutter#132347)
2023-08-10 [email protected] Roll Flutter Engine from 16b01b98af20 to b019ac62f21f (1 revision) (flutter/flutter#132341)
2023-08-10 [email protected] Update `flutter_tools/bin/*.(dart|sh)` to provide, if set, --local-engine-host. (flutter/flutter#132336)
2023-08-10 [email protected] Update application id and bundle id of a11y assessment app (flutter/flutter#132334)
2023-08-10 [email protected] Roll Flutter Engine from a9be77e6f475 to 16b01b98af20 (6 revisions) (flutter/flutter#132332)
2023-08-10 [email protected] Remove the fast reassemble / single widget reload feature (flutter/flutter#132255)
2023-08-10 [email protected] Analyze code snippets in integration_test docs (flutter/flutter#132314)
2023-08-10 [email protected] Adds SemanticsNode Finders for searching the semantics tree (flutter/flutter#127137)
2023-08-10 [email protected] TextField should correctly resolve provided style for material states (flutter/flutter#132330)
2023-08-10 [email protected] setState documentation (flutter/flutter#132090)
2023-08-10 [email protected] Roll Flutter Engine from ea7730c16301 to a9be77e6f475 (6 revisions) (flutter/flutter#132328)
2023-08-10 [email protected] Fix: use --web-launch-url and --web-hostname arguments in flutter drive (flutter/flutter#131763)
2023-08-10 [email protected] GridView sample code (flutter/flutter#131900)
2023-08-10 [email protected] Upgrade flutter packages. (flutter/flutter#132326)
2023-08-10 [email protected] TextPainter migration cleanup (flutter/flutter#132317)
2023-08-10 [email protected] An example of parentData usage. (flutter/flutter#131818)
2023-08-10 [email protected] Add hasInteractedByUser getter in FormField (flutter/flutter#131539)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
a7997f6 Update dev/devicelab/** to provide --local-engine-host. (f…
ef81f81 
…lutter/flutter#132342)
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Roll Flutter from 685141b to 9b6945b (25 revisions) (flutter#4680)
5b890e9 
flutter/flutter@685141b...9b6945b

2023-08-11 [email protected] Roll Flutter Engine from 93e8901490e7 to 77dfeea40e10 (1 revision) (flutter/flutter#132389)
2023-08-11 [email protected] Roll Flutter Engine from 4e532b957225 to 93e8901490e7 (1 revision) (flutter/flutter#132381)
2023-08-11 [email protected] Roll Flutter Engine from 25afdb9b696d to 4e532b957225 (4 revisions) (flutter/flutter#132376)
2023-08-11 [email protected] Roll Flutter Engine from da23fb0d9a1d to 25afdb9b696d (1 revision) (flutter/flutter#132370)
2023-08-11 [email protected] Roll Flutter Engine from acd1bc5536ef to da23fb0d9a1d (2 revisions) (flutter/flutter#132367)
2023-08-11 [email protected] Roll Flutter Engine from 578a8e8aabf6 to acd1bc5536ef (1 revision) (flutter/flutter#132365)
2023-08-11 [email protected] Roll Flutter Engine from 18a71c031f5f to 578a8e8aabf6 (1 revision) (flutter/flutter#132364)
2023-08-11 [email protected] Update `dev/devicelab/**` to provide `--local-engine-host`. (flutter/flutter#132342)
2023-08-10 [email protected] Roll Flutter Engine from b019ac62f21f to 18a71c031f5f (2 revisions) (flutter/flutter#132347)
2023-08-10 [email protected] Roll Flutter Engine from 16b01b98af20 to b019ac62f21f (1 revision) (flutter/flutter#132341)
2023-08-10 [email protected] Update `flutter_tools/bin/*.(dart|sh)` to provide, if set, --local-engine-host. (flutter/flutter#132336)
2023-08-10 [email protected] Update application id and bundle id of a11y assessment app (flutter/flutter#132334)
2023-08-10 [email protected] Roll Flutter Engine from a9be77e6f475 to 16b01b98af20 (6 revisions) (flutter/flutter#132332)
2023-08-10 [email protected] Remove the fast reassemble / single widget reload feature (flutter/flutter#132255)
2023-08-10 [email protected] Analyze code snippets in integration_test docs (flutter/flutter#132314)
2023-08-10 [email protected] Adds SemanticsNode Finders for searching the semantics tree (flutter/flutter#127137)
2023-08-10 [email protected] TextField should correctly resolve provided style for material states (flutter/flutter#132330)
2023-08-10 [email protected] setState documentation (flutter/flutter#132090)
2023-08-10 [email protected] Roll Flutter Engine from ea7730c16301 to a9be77e6f475 (6 revisions) (flutter/flutter#132328)
2023-08-10 [email protected] Fix: use --web-launch-url and --web-hostname arguments in flutter drive (flutter/flutter#131763)
2023-08-10 [email protected] GridView sample code (flutter/flutter#131900)
2023-08-10 [email protected] Upgrade flutter packages. (flutter/flutter#132326)
2023-08-10 [email protected] TextPainter migration cleanup (flutter/flutter#132317)
2023-08-10 [email protected] An example of parentData usage. (flutter/flutter#131818)
2023-08-10 [email protected] Add hasInteractedByUser getter in FormField (flutter/flutter#131539)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@engine-flutter-autoroll
Roll Flutter from 685141b to 9b6945b (25 revisions) (flutter#4680)
dd30bb4 
flutter/flutter@685141b...9b6945b

2023-08-11 [email protected] Roll Flutter Engine from 93e8901490e7 to 77dfeea40e10 (1 revision) (flutter/flutter#132389)
2023-08-11 [email protected] Roll Flutter Engine from 4e532b957225 to 93e8901490e7 (1 revision) (flutter/flutter#132381)
2023-08-11 [email protected] Roll Flutter Engine from 25afdb9b696d to 4e532b957225 (4 revisions) (flutter/flutter#132376)
2023-08-11 [email protected] Roll Flutter Engine from da23fb0d9a1d to 25afdb9b696d (1 revision) (flutter/flutter#132370)
2023-08-11 [email protected] Roll Flutter Engine from acd1bc5536ef to da23fb0d9a1d (2 revisions) (flutter/flutter#132367)
2023-08-11 [email protected] Roll Flutter Engine from 578a8e8aabf6 to acd1bc5536ef (1 revision) (flutter/flutter#132365)
2023-08-11 [email protected] Roll Flutter Engine from 18a71c031f5f to 578a8e8aabf6 (1 revision) (flutter/flutter#132364)
2023-08-11 [email protected] Update `dev/devicelab/**` to provide `--local-engine-host`. (flutter/flutter#132342)
2023-08-10 [email protected] Roll Flutter Engine from b019ac62f21f to 18a71c031f5f (2 revisions) (flutter/flutter#132347)
2023-08-10 [email protected] Roll Flutter Engine from 16b01b98af20 to b019ac62f21f (1 revision) (flutter/flutter#132341)
2023-08-10 [email protected] Update `flutter_tools/bin/*.(dart|sh)` to provide, if set, --local-engine-host. (flutter/flutter#132336)
2023-08-10 [email protected] Update application id and bundle id of a11y assessment app (flutter/flutter#132334)
2023-08-10 [email protected] Roll Flutter Engine from a9be77e6f475 to 16b01b98af20 (6 revisions) (flutter/flutter#132332)
2023-08-10 [email protected] Remove the fast reassemble / single widget reload feature (flutter/flutter#132255)
2023-08-10 [email protected] Analyze code snippets in integration_test docs (flutter/flutter#132314)
2023-08-10 [email protected] Adds SemanticsNode Finders for searching the semantics tree (flutter/flutter#127137)
2023-08-10 [email protected] TextField should correctly resolve provided style for material states (flutter/flutter#132330)
2023-08-10 [email protected] setState documentation (flutter/flutter#132090)
2023-08-10 [email protected] Roll Flutter Engine from ea7730c16301 to a9be77e6f475 (6 revisions) (flutter/flutter#132328)
2023-08-10 [email protected] Fix: use --web-launch-url and --web-hostname arguments in flutter drive (flutter/flutter#131763)
2023-08-10 [email protected] GridView sample code (flutter/flutter#131900)
2023-08-10 [email protected] Upgrade flutter packages. (flutter/flutter#132326)
2023-08-10 [email protected] TextPainter migration cleanup (flutter/flutter#132317)
2023-08-10 [email protected] An example of parentData usage. (flutter/flutter#131818)
2023-08-10 [email protected] Add hasInteractedByUser getter in FormField (flutter/flutter#131539)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matanlurey @gaaclarke