[Impeller] Investigate remaining Flutter gallery performance issues on Vulkan/GLES. #132690

Activity

1. jonahwilliams

   added

   e: impellerImpeller rendering backend issues and features requestsImpeller rendering backend issues and features requests

   team-engineOwned by Engine teamOwned by Engine team

   on Aug 16, 2023
2. github-project-automation

   added this to Impelleron Aug 16, 2023
3. github-project-automation

   moved this to 🤔 Needs Triage in Impelleron Aug 16, 2023
4. jonahwilliams commented on Aug 18, 2023

   

   jonahwilliams

   on Aug 18, 2023

   ContributorAuthor

   More actions

   The slow render pass encoding reproduces on a Pixel 7 as well. Here is a highly annotated trace:

   

   In this case, GARBO2 is a trace event I added in the command pool recycler:

   void CommandPoolVK::GarbageCollectBuffersIfAble() {
       TRACE_EVENT0("impeller", "CommandPoolVK::GARBO2");
     if (std::this_thread::get_id() != owner_id_) {
       return;
     }
     buffers_to_collect_.clear();
   }
   
   

   So I suspect the issue may be destroying command pools is stalling on the raster thread. We should re-arrange this code to use the resource manager if possible.
5. gaaclarke commented on Aug 19, 2023

   

   gaaclarke

   on Aug 19, 2023

   Member

   More actions

   We noted this offline too, but just creating and deleting CommandPoolVK and command buffers may be faster than the synchronization that was added to try to cache them. Also it seems like maybe CommandPoolVK is built on the assumption that the command buffers need to be deleted on the raster thread which shouldn't be the case. Since the tracked objects is trying to delete it on the resource tracker thread, we should be able to delete them safely there.
6. chinmaygarde

   added

   P1High-priority issues at the top of the work listHigh-priority issues at the top of the work list

   on Aug 21, 2023
7. chinmaygarde

   assigned

   jonahwilliams

   on Aug 21, 2023
8. chinmaygarde

   added

   triaged-engineTriaged by Engine teamTriaged by Engine team

   on Aug 21, 2023
9. gaaclarke

   added a commit that references this issue on Aug 21, 2023

   [Impeller] Added recycled command buffers. (#44904)

   ...

   525df86
10. chinmaygarde

    moved this from 🤔 Needs Triage to ⚙️ In Progress in Impelleron Aug 22, 2023
11. jonahwilliams

    added a commit that references this issue on Aug 22, 2023

    Shrink image sizes of attachments in Reply app. (#996)

    ...

    ecfb9e5
12. chinmaygarde

    changed the title [-][Impeller] investigate remaining Flutter gallery performance issues on Vulkan/Gles.[/-] [+][Impeller] Investigate remaining Flutter gallery performance issues on Vulkan/GLES.[/+] on Aug 22, 2023
13. auto-submit

    added a commit that references this issue on Aug 22, 2023

    [gallery] roll gallery to ecfb9e5352bd12032301b12b30d5853d83d89bda (#…

    ...

    00a99d3
14. gaaclarke

    added a commit that references this issue on Aug 30, 2023

    [Impeller] Added recycled command buffers. (flutter-team-archive#44904)

    ...

    0fd00ae
15. jonahwilliams commented on Sep 25, 2023

    

    jonahwilliams

    on Sep 25, 2023

    ContributorAuthor

    More actions

    Closing as a duplicate of #135443
16. jonahwilliams

    closed this as completedon Sep 25, 2023
17. github-project-automation

    moved this from ⚙️ In Progress to ✅ Done in Impelleron Sep 25, 2023
18. github-actions commented on Oct 9, 2023

    

    github-actionsbot

    on Oct 9, 2023

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
19. github-actions

    locked as resolved and limited conversation to collaborators on Oct 9, 2023