Skip to content

[CP] Space character should be optional when tree shaking fonts on 3.14 #132978

Closed

Description

@christopherfujino

Issue Link

#132711

Commit Hash

376993f

Target

beta 3.14

PR Link

engine: flutter-team-archive/engine#44908
framework: #132977

Changelog Description

Fixes an issue with tree shaking fonts that do not contain a space glyph.

Impacted Users

Flutter Web apps that have custom fonts that do not contain a space glyph

Impact Description

The flutter tool fails out with an error when attempting to compile an app that uses a custom icon font that does not contain a space.

Workaround

The user can pass --no-tree-shake-icons to prevent icon tree shaking, which will allow the flutter tool to complete the build process. However, it skips icon tree shaking, which bloats the payload size of their font files.

Risk

low

Test Coverage

yes

Validation Steps

New integration tests have been added that ensure that the font-subset tool can handle optional characters. Subsequent testing will happen with the framework change, which will follow.

Activity

  1. added
    cp: mergedCherry-pick has been merged to the release branch.
    on Aug 31, 2023
  2. github-actions commented on Sep 15, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  3. locked as resolved and limited conversation to collaborators on Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

cp: approvedApproved cherry-pick requestcp: merge-to-betaCherry-picks that should be merged to betacp: mergedCherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions