Skip to content

FilterChip should have DeletableChipAttributes/trailing to match Material 3 spec. #135595

Closed
#136645
Closed
FilterChip should have DeletableChipAttributes/trailing to match Material 3 spec.#135595
#136645
Assignees
TahaTesser
Labels
P2Important issues not at the top of the work listc: new featureNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to Flutterframeworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packagesr: fixedIssue is closed as already fixed in a newer versionteam-designOwned by Design Languages teamtriaged-designTriaged by Design Languages team

Description

@Jonas-Sander
Jonas-Sander
opened on Sep 27, 2023

Is there an existing issue for this?

Use case

I'm trying to present several filters that a user can choose from, like shown here in the material 3 spec.

Additionally the user should be able to create more filter with a custom value. These custom filters should be deletable. Such a filter chip with the "X" symbol is shown in the material 3 spec right here.

Note: In the last link the description says: "[...] filter chips may contain a trailing icon to directly remove the chip [...]" but subtext beneath the illustration says: "The X close icon indicates that a user can unselect the filter chip". I'm very sure "unselect" is wrong and should be replaced with "delete", since one can already unselect by tapping on the chip and as the "X" means deleting on other chip types.

Proposal

Add DeletableChipAttributes to FilterChip.

Note: As there is also an example with a "trailing menu item" maybe there should be a trailing attribute instead of only onDeleted etc? But as _RawChip specifically mentions deleteIcon I'm not sure if this would require a refactoring of other chip types as well.

Activity

  1. Jonas-Sander
    changed the title [-]`FilterChip` should have `DeletableChipAttributes` to match Material 3 spec.[/-] [+]`FilterChip` should have `DeletableChipAttributes`/`trailing` to match Material 3 spec.[/+] on Sep 27, 2023
  2. TahaTesser
    added
    in triagePresently being triaged by the triage team
    frameworkflutter/packages/flutter repository. See also f: labels.
    p: material_uimaterial_ui package in flutter/packages
    team-designOwned by Design Languages team
    and removed
    in triagePresently being triaged by the triage team
    on Sep 27, 2023
  3. TahaTesser
    self-assigned this
    on Sep 27, 2023
  4. TahaTesser
    added this to Nevercodeand Material 3on Sep 27, 2023
  5. github-project-automation
    moved this to To do in Nevercodeon Sep 27, 2023
  6. TahaTesser
    added
    c: proposalA detailed proposal for a change to Flutter
    on Sep 27, 2023

  7. TahaTesser commented on Sep 27, 2023

    @TahaTesser
    TahaTesser
    on Sep 27, 2023
    Contributor

    Thanks for the issue! @Jonas-Sander

  8. HansMuller
    added
    P2Important issues not at the top of the work list
    triaged-designTriaged by Design Languages team
    on Sep 27, 2023

  9. TahaTesser commented on Sep 28, 2023

    @TahaTesser
    TahaTesser
    on Sep 28, 2023
    Contributor

    This seems to be an updated FilterChip specs
    Screenshot 2023-09-28 at 13 43 05

    I remember there was no trailing button in the FilterChip specs. It can be confirmed using the Wayback Machine (March 2023)
    Screenshot 2023-09-28 at 13 42 54

  10. TahaTesser
    moved this to 🗺 Planned in Material 3on Sep 28, 2023
  11. TahaTesser
    added
    c: new featureNothing broken; request for a new capability
    on Sep 28, 2023

  12. TahaTesser commented on Oct 3, 2023

    @TahaTesser
    TahaTesser
    on Oct 3, 2023
    Contributor

    blocked by #135751

  13. TahaTesser
    moved this from 🗺 Planned to 🚧 In Progress in Material 3on Oct 16, 2023
  14. TahaTesser
    moved this from To do to In progress in Nevercodeon Oct 16, 2023
  15. TahaTesser
    moved this from In progress to PR submitted in Nevercodeon Oct 16, 2023
  16. auto-submit
    closed this as completedin #136645on Oct 23, 2023
  17. github-project-automation
    moved this from 🚧 In Progress to ✅ Done in Material 3on Oct 23, 2023
  18. github-project-automation
    moved this from PR submitted to Done (PR merged) in Nevercodeon Oct 23, 2023
  19. auto-submit
    added a commit that references this issue on Oct 23, 2023

    Add delete button support to `FilterChip` (#136645)

    6c3010e
  20. TahaTesser
    added
    r: fixedIssue is closed as already fixed in a newer version
    on Oct 24, 2023

  21. github-actions commented on Nov 7, 2023

    @github-actions
    github-actionsbot
    on Nov 7, 2023 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  22. github-actions
    locked as resolved and limited conversation to collaborators on Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listc: new featureNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to Flutterframeworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packagesr: fixedIssue is closed as already fixed in a newer versionteam-designOwned by Design Languages teamtriaged-designTriaged by Design Languages team

Type

No type

Projects

  • Nevercode
    Status
    Done (PR merged)

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions