Skip to content

[Android] Add 'Share' button to selection controls #138728

Description

@bleroux

Is there an existing issue for this?

Use case

A native Android app shows the 'Share' option in the selection context menu (before 'Select all') :

For a TextField:
Capture d’écran du 2023-11-20 17-19-02

For a TextView:
Capture d’écran du 2023-11-20 17-19-23

Proposal

On Android, add the 'Share' option to the Flutter selection menu (both for Selectable region and TextField).

This is part of #107578 which is very broad (all plaforms and all missing menu options).
Creating this issue to make it easier to follow.

Implementation steps

The 'share' feature is already supported on iOS (see #132599 and flutter-team-archive/engine#44554), the steps to support it on Android are:

# Status Description Related Work
1 Done Add Android support for the PlatformChannel Share.invoke message (engine side). flutter-team-archive/engine#48265
2 Done Change the Share... label to Share in material_localizations.dart (Android native label does not have the same ... that iOS native label has). #138899
3 Done Add the share option to the selection menu for EditableText (it should be displayed when there is some text selected and it should appears before Select all. #139479
4 Done Add the share option to the selection menu for SelectionRegion #141447

Activity

  1. added
    in triagePresently being triaged by the triage team
    a: text inputEntering text in a text field or keyboard related problems
    platform-androidAndroid applications specifically
    c: proposalA detailed proposal for a change to Flutter
    and removed
    in triagePresently being triaged by the triage team
    on Nov 20, 2023
  2. self-assigned this
    on Nov 20, 2023
  3. added
    P1High-priority issues at the top of the work list
    on Nov 20, 2023
  4. bleroux commented on Nov 20, 2023

    @bleroux
    ContributorAuthor

    Labelling P1, because it is a feature we hope to add for the next stable release and on which I will focus.

  5. added
    a: fidelityMatching the OEM platforms better
    team-designOwned by Design Languages team
    p: material_uimaterial_ui package in flutter/packages
    and removed on Dec 1, 2023
  6. moved this from To do to In progress in Nevercodeon Dec 1, 2023
  7. moved this from In progress to PR submitted in Nevercodeon Dec 7, 2023
  8. moved this from PR submitted to Done (PR merged) in Nevercodeon Dec 8, 2023
  9. added
    r: fixedIssue is closed as already fixed in a newer version
    on Dec 8, 2023
  10. github-actions commented on Dec 22, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  11. locked as resolved and limited conversation to collaborators on Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work lista: fidelityMatching the OEM platforms bettera: text inputEntering text in a text field or keyboard related problemsc: proposalA detailed proposal for a change to Flutterp: material_uimaterial_ui package in flutter/packagesplatform-androidAndroid applications specificallyr: fixedIssue is closed as already fixed in a newer versionteam-designOwned by Design Languages team

Type

No type

Projects

  • Status
    Done (PR merged)

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions