Skip to content

[Flutter GPU] Standardize a message error pattern. #143891

Closed
#162104
Closed
[Flutter GPU] Standardize a message error pattern.#143891
#162104
Labels
P2Important issues not at the top of the work listc: proposalA detailed proposal for a change to Flutterengineflutter/engine related. See also e: labels.flutter-gpur: fixedIssue is closed as already fixed in a newer versionteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Description

@bdero
bdero
opened on Feb 21, 2024

Part of #130921

Right now, we have a mix of error handling that may be confusing to users.

  • Sometimes a success boolean is returned.
  • Sometimes an exception is thrown if there's a problem.
  • Sometimes Impeller validation will catch problems and rendering will fail.
  • Sometimes the Impeller backend will allow something invalid to happen and rendering will silently fail unless the user has Metal or Vulkan validations enabled.

Recommendation: Bias heavily towards exception throwing.

Activity

  1. bdero
    added
    e: impellerImpeller rendering backend issues and features requests
    on Feb 21, 2024
  2. danagbemava-nc
    added
    engineflutter/engine related. See also e: labels.
    team-engineOwned by Engine team
    c: proposalA detailed proposal for a change to Flutter
    on Feb 22, 2024
  3. bdero
    changed the title [-][Impeller] Flutter GPU: Standardize a message error pattern.[/-] [+][Flutter GPU] Standardize a message error pattern.[/+] on Feb 24, 2024
  4. bdero
    removed
    e: impellerImpeller rendering backend issues and features requests
    on Feb 24, 2024
  5. jonahwilliams
    added
    P2Important issues not at the top of the work list
    on Feb 26, 2024
  6. chinmaygarde
    added
    flutter-gpu
    on Feb 27, 2024
  7. github-project-automation
    added this to Flutter GPUon Feb 27, 2024
  8. github-project-automation
    moved this to Needs Triage in Flutter GPUon Feb 27, 2024
  9. chinmaygarde
    moved this from 🤔 Needs Triage to 🔧 Internals in Flutter GPUon Feb 27, 2024
  10. jonahwilliams
    added
    triaged-engineTriaged by Engine team
    on Mar 4, 2024

  11. bdero commented on Sep 24, 2024

    @bdero
    bdero
    on Sep 24, 2024
    MemberAuthor

    For dart-side parameter guards, use message asserts instead of exception branches.

  12. github-merge-queue
    added a commit that references this issue on Feb 1, 2025

    [Flutter GPU] Breaking: Use exceptions for resource creation errors. (#…

    039d0db
  13. bdero
    closed this as completedin #162104on Feb 1, 2025
  14. github-project-automation
    moved this from 🔧 Internals to ✅ Done in Flutter GPUon Feb 1, 2025
  15. danagbemava-nc
    added
    r: fixedIssue is closed as already fixed in a newer version
    on Feb 4, 2025

  16. github-actions commented on Feb 18, 2025

    @github-actions
    github-actionsbot
    on Feb 18, 2025 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  17. github-actions
    locked as resolved and limited conversation to collaborators on Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: proposalA detailed proposal for a change to Flutterengineflutter/engine related. See also e: labels.flutter-gpur: fixedIssue is closed as already fixed in a newer versionteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions