Skip to content

CupertinoTextFormFieldRow is missing restorationId parameter #144504

Closed
#144541
Closed
CupertinoTextFormFieldRow is missing restorationId parameter#144504
#144541
Assignees
bleroux
Labels
a: state restorationRestorationManager and related APIsc: new featureNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to Flutterp: cupertino_uicupertino_ui package in flutter/packagesr: fixedIssue is closed as already fixed in a newer versionteam-designOwned by Design Languages team

Description

@triallax
triallax
opened on Mar 2, 2024

Use case

I wanted to add state restoration support to my app, but the CupertinoTextFormFieldRow constructor is missing the restorationId parameter (which it could simply pass to the CupertinoTextField it's wrapping).

Proposal

Just add the restorationId parameter to the CupertinoTextFormFieldRow constructor.

Activity

  1. danagbemava-nc
    added
    in triagePresently being triaged by the triage team
    c: new featureNothing broken; request for a new capability
    p: cupertino_uicupertino_ui package in flutter/packages
    c: proposalA detailed proposal for a change to Flutter
    team-designOwned by Design Languages team
    a: state restorationRestorationManager and related APIs
    and removed
    in triagePresently being triaged by the triage team
    on Mar 4, 2024
  2. bleroux
    self-assigned this
    on Mar 4, 2024
  3. bleroux
    added this to Nevercodeon Mar 4, 2024
  4. bleroux
    moved this from To do to In progress in Nevercodeon Mar 4, 2024
  5. github-project-automation
    moved this to To do in Nevercodeon Mar 4, 2024

  6. piedcipher commented on Mar 4, 2024

    @piedcipher
    piedcipher
    on Mar 4, 2024
    Member

    I was about to pick it up but got confused because parent class already has a restorationId.

  7. bleroux
    moved this from In progress to PR submitted in Nevercodeon Mar 4, 2024
  8. auto-submit
    closed this as completedin #144541on Mar 5, 2024
  9. auto-submit
    added a commit that references this issue on Mar 5, 2024

    Restorable CupertinoTextFormFieldRow (#144541)

    67e6cad
  10. github-project-automation
    moved this from PR submitted to Done (PR merged) in Nevercodeon Mar 5, 2024
  11. bleroux
    added
    r: fixedIssue is closed as already fixed in a newer version
    on Mar 5, 2024

  12. github-actions commented on Mar 19, 2024

    @github-actions
    github-actionsbot
    on Mar 19, 2024 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  13. github-actions
    locked as resolved and limited conversation to collaborators on Mar 19, 2024
  14. chunhtai
    added a commit that references this issue on Jun 12, 2026

    Restorable CupertinoTextFormFieldRow (#144541)

    16ccc47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

a: state restorationRestorationManager and related APIsc: new featureNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to Flutterp: cupertino_uicupertino_ui package in flutter/packagesr: fixedIssue is closed as already fixed in a newer versionteam-designOwned by Design Languages team

Type

No type

Projects

  • Nevercode
    Status
    Done (PR merged)

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions