Skip to content

Bring CupertinoSwitch up to speed with Switch.adaptive #149275

Closed
#149465
Closed
Bring CupertinoSwitch up to speed with Switch.adaptive#149275
#149465
Labels
P1High-priority issues at the top of the work lista: fidelityMatching the OEM platforms betterc: new featureNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to Flutterframeworkflutter/packages/flutter repository. See also f: labels.p: cupertino_uicupertino_ui package in flutter/packagesteam-designOwned by Design Languages teamtriaged-designTriaged by Design Languages team

Description

@victorsanni
victorsanni
opened on May 29, 2024

Use case

There are two independent iOS-style switch implementations: Switch.adaptive and CupertinoSwitch.

CupertinoSwitch should support some functionality that Switch has, such as:

  • Ability to customize mouse cursors.
  • Ability to customize track outline color and width.
  • Ability to customize thumb color in both active and inactive states.
  • Ability to show an image/icon on the thumb.
  • Ability to resolve properties in different WidgetStates.

Most of these capabilities are already provided via Switch.adaptive on iOS/macOS. However, CupertinoSwitch should also provide these capabilities. This is also an opportunity to bring the Switch and CupertinoSwitch APIs closer together.

Proposal

Part 1

Add these capabilities to CupertinoSwitch.

Part 2

Also, a decision should be made about having Switch.adaptive delegate to CupertinoSwitch so that there are not two independent iOS-style Switch implementations.

Activity

  1. huycozy
    added
    in triagePresently being triaged by the triage team
    c: new featureNothing broken; request for a new capability
    frameworkflutter/packages/flutter repository. See also f: labels.
    a: fidelityMatching the OEM platforms better
    p: cupertino_uicupertino_ui package in flutter/packages
    c: proposalA detailed proposal for a change to Flutter
    team-designOwned by Design Languages team
    and removed
    in triagePresently being triaged by the triage team
    on May 30, 2024
  2. Piinks
    added
    triaged-designTriaged by Design Languages team
    P2Important issues not at the top of the work list
    on Jun 5, 2024
  3. Piinks
    assigned
    victorsanni
    on Jun 17, 2024
  4. auto-submit
    added a commit that references this issue on Jul 12, 2024

    Roll `Switch.adaptive` changes into `CupertinoSwitch` (#149465)

    dddea4d

  5. victorsanni commented on Jul 25, 2024

    @victorsanni
    victorsanni
    on Jul 25, 2024
    ContributorAuthor

    Part 1 resolved by #149465.

  6. Piinks
    added
    P1High-priority issues at the top of the work list
    and removed
    P2Important issues not at the top of the work list
    on Jul 25, 2024
  7. Piinks
    added this to Cupertino Refreshon Jul 25, 2024
  8. Piinks
    moved this to In Progress in Cupertino Refreshon Jul 25, 2024
  9. victorsanni
    changed the title [-]Improve fidelity and customizability of `CupertinoSwitch`[/-] [+]Bring `CupertinoSwitch` up to speed with `Switch.adaptive`[/+] on Jul 29, 2024

  10. victorsanni commented on Jul 29, 2024

    @victorsanni
    victorsanni
    on Jul 29, 2024
    ContributorAuthor

    In order to make this issue more actionable, I will close this issue and create a separate issue for Part 2.

  11. victorsanni
    closed this as completedon Jul 29, 2024
  12. github-project-automation
    moved this from In Progress to Done in Cupertino Refreshon Jul 29, 2024
  13. victorsanni
    removed their assignment
    on Aug 3, 2024

  14. github-actions commented on Aug 17, 2024

    @github-actions
    github-actionsbot
    on Aug 17, 2024 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  15. github-actions
    locked as resolved and limited conversation to collaborators on Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1High-priority issues at the top of the work lista: fidelityMatching the OEM platforms betterc: new featureNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to Flutterframeworkflutter/packages/flutter repository. See also f: labels.p: cupertino_uicupertino_ui package in flutter/packagesteam-designOwned by Design Languages teamtriaged-designTriaged by Design Languages team

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions