Repository navigation
Change in dart:io writeln behavior causing engine -> framework roll failures #153163
Description
Starting with #153148, which contains only the Dart -> Engine roll with commits: https://dart.googlesource.com/sdk.git/+log/9222e4c96f4d..1cc09f3f3642, the engine is failing to roll to the framework. The failures are in Flutter CLI tests that check strings emitted on streams match expected values as in:
It looks like the change that led to this was: https://dart.googlesource.com/sdk.git/+/e8c035308bec001af477d644f3a5c396dedc94ff
cc @a-siva.
I think we could probably just update the string expectations of the tests in the framework.
Activity
aam commentedon Aug 9, 2024
The fix for the test have landed #153147
zanderso commentedon Aug 9, 2024
I'm seeing some more instances like here https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20tool_tests_commands/38940/overview, so we may have to chase this a bit further.
Update the flutter_tools symbolize_test to handle a change to writeln…
Fix tests expectations regarding new lines.
Fix tests expectations regarding new lines. (#153174)
Fix tests expectations regarding new lines. (flutter#153174)
github-actions commentedon Aug 23, 2024
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.Fix tests expectations regarding new lines. (flutter#153174)