Skip to content

Fix tests expectations regarding new lines. - #153174

Merged
aam merged 3 commits into
flutter:masterfrom
aam:fix-newline-tests
Aug 9, 2024
Merged

aam merged 3 commits into
flutter:masterfrom
aam:fix-newline-tests

Conversation

@aam

@aam aam commented Aug 9, 2024

Copy link
Copy Markdown
Member

Fixes #153163

dart sdk change that affected tests is dart-lang/sdk@e8c0353

@github-actions github-actions Bot added tool Affects the "flutter" command-line tool. See also t: labels. engine flutter/engine related. See also e: labels. labels Aug 9, 2024
@aam

aam commented Aug 9, 2024

Copy link
Copy Markdown
Member Author

cc @jason-simmons

@github-actions github-actions Bot removed the engine flutter/engine related. See also e: labels. label Aug 9, 2024
@aam
aam merged commit 22e6af6 into flutter:master Aug 9, 2024
@aam
aam deleted the fix-newline-tests branch August 9, 2024 17:31
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 9, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 9, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 9, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2024
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Aug 10, 2024
Manual roll requested by [email protected]

flutter/flutter@76107bd...b12d861

2024-08-10 [email protected] Move windows mokey tests to prod (flutter/flutter#153203)
2024-08-10 [email protected] Roll Flutter Engine from 2f577d8e3fa2 to 3acd373923c9 (7 revisions) (flutter/flutter#153210)
2024-08-09 [email protected] Also run Linux_android_emu tests on API level 34 image (flutter/flutter#153175)
2024-08-09 [email protected] Expose affixes icon constraints in InputDecorationTheme (flutter/flutter#153089)
2024-08-09 [email protected] Spell check range error (flutter/flutter#153055)
2024-08-09 [email protected] Roll Flutter Engine from 4d5b1df96fc9 to 2f577d8e3fa2 (4 revisions) (flutter/flutter#153191)
2024-08-09 [email protected] Roll Flutter Engine from c9ec468c7592 to 4d5b1df96fc9 (6 revisions) (flutter/flutter#153182)
2024-08-09 [email protected] Roll Packages from bb797b9 to f7b1256 (5 revisions) (flutter/flutter#153180)
2024-08-09 [email protected] Move Cupertino focus constants to cupertino/constants.dart (flutter/flutter#153115)
2024-08-09 [email protected] Fix tests expectations regarding new lines. (flutter/flutter#153174)
2024-08-09 [email protected] Shift tests on moto g4 on Windows hosts to mokey in staging (flutter/flutter#153167)
2024-08-09 [email protected] Make ios_deploy_test.dart more robust (flutter/flutter#153147)
2024-08-09 [email protected] Roll Flutter Engine from e50fd307b6f7 to c9ec468c7592 (2 revisions) (flutter/flutter#153145)
2024-08-09 [email protected] Roll Flutter Engine from 05208896830a to e50fd307b6f7 (5 revisions) (flutter/flutter#153143)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33 pushed a commit to DBowen33/flutter that referenced this pull request Aug 16, 2024
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
)

Manual roll requested by [email protected]

flutter/flutter@76107bd...b12d861

2024-08-10 [email protected] Move windows mokey tests to prod (flutter/flutter#153203)
2024-08-10 [email protected] Roll Flutter Engine from 2f577d8e3fa2 to 3acd373923c9 (7 revisions) (flutter/flutter#153210)
2024-08-09 [email protected] Also run Linux_android_emu tests on API level 34 image (flutter/flutter#153175)
2024-08-09 [email protected] Expose affixes icon constraints in InputDecorationTheme (flutter/flutter#153089)
2024-08-09 [email protected] Spell check range error (flutter/flutter#153055)
2024-08-09 [email protected] Roll Flutter Engine from 4d5b1df96fc9 to 2f577d8e3fa2 (4 revisions) (flutter/flutter#153191)
2024-08-09 [email protected] Roll Flutter Engine from c9ec468c7592 to 4d5b1df96fc9 (6 revisions) (flutter/flutter#153182)
2024-08-09 [email protected] Roll Packages from bb797b9 to f7b1256 (5 revisions) (flutter/flutter#153180)
2024-08-09 [email protected] Move Cupertino focus constants to cupertino/constants.dart (flutter/flutter#153115)
2024-08-09 [email protected] Fix tests expectations regarding new lines. (flutter/flutter#153174)
2024-08-09 [email protected] Shift tests on moto g4 on Windows hosts to mokey in staging (flutter/flutter#153167)
2024-08-09 [email protected] Make ios_deploy_test.dart more robust (flutter/flutter#153147)
2024-08-09 [email protected] Roll Flutter Engine from e50fd307b6f7 to c9ec468c7592 (2 revisions) (flutter/flutter#153145)
2024-08-09 [email protected] Roll Flutter Engine from 05208896830a to e50fd307b6f7 (5 revisions) (flutter/flutter#153143)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
)

Manual roll requested by [email protected]

flutter/flutter@76107bd...b12d861

2024-08-10 [email protected] Move windows mokey tests to prod (flutter/flutter#153203)
2024-08-10 [email protected] Roll Flutter Engine from 2f577d8e3fa2 to 3acd373923c9 (7 revisions) (flutter/flutter#153210)
2024-08-09 [email protected] Also run Linux_android_emu tests on API level 34 image (flutter/flutter#153175)
2024-08-09 [email protected] Expose affixes icon constraints in InputDecorationTheme (flutter/flutter#153089)
2024-08-09 [email protected] Spell check range error (flutter/flutter#153055)
2024-08-09 [email protected] Roll Flutter Engine from 4d5b1df96fc9 to 2f577d8e3fa2 (4 revisions) (flutter/flutter#153191)
2024-08-09 [email protected] Roll Flutter Engine from c9ec468c7592 to 4d5b1df96fc9 (6 revisions) (flutter/flutter#153182)
2024-08-09 [email protected] Roll Packages from ca14728 to 709205e (5 revisions) (flutter/flutter#153180)
2024-08-09 [email protected] Move Cupertino focus constants to cupertino/constants.dart (flutter/flutter#153115)
2024-08-09 [email protected] Fix tests expectations regarding new lines. (flutter/flutter#153174)
2024-08-09 [email protected] Shift tests on moto g4 on Windows hosts to mokey in staging (flutter/flutter#153167)
2024-08-09 [email protected] Make ios_deploy_test.dart more robust (flutter/flutter#153147)
2024-08-09 [email protected] Roll Flutter Engine from e50fd307b6f7 to c9ec468c7592 (2 revisions) (flutter/flutter#153145)
2024-08-09 [email protected] Roll Flutter Engine from 05208896830a to e50fd307b6f7 (5 revisions) (flutter/flutter#153143)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change in dart:io writeln behavior causing engine -> framework roll failures

2 participants