Repository navigation
Move Cupertino focus constants to cupertino/constants.dart - #153115
Merged
Merged
Conversation
github-actions
Bot
added
framework
victorsanni
marked this pull request as ready for review
August 8, 2024 18:20
9 tasks done
Comment on lines
288
to
+291
| .fromColor((backgroundColor ?? CupertinoColors.activeBlue) | ||
| .withOpacity(_kCupertinoFocusColorOpacity)) | ||
| .withLightness(_kCupertinoFocusColorBrightness) | ||
| .withSaturation(_kCupertinoFocusColorSaturation) | ||
| .withOpacity(kCupertinoFocusColorOpacity)) | ||
| .withLightness(kCupertinoFocusColorBrightness) | ||
| .withSaturation(kCupertinoFocusColorSaturation) |
Contributor
There was a problem hiding this comment.
It looks a little odd that it is all in a line when it's not directly chaining. Maybe?
HSLColor
.fromColor((backgroundColor ?? CupertinoColors.activeBlue)
.withOpacity(kCupertinoFocusColorOpacity)
).withLightness(kCupertinoFocusColorBrightness)
.withSaturation(kCupertinoFocusColorSaturation)
or something?
Contributor
Author
There was a problem hiding this comment.
That's true. The cascade does look nice though :)
victorsanni
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 10, 2024
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 10, 2024
Manual roll requested by [email protected] flutter/flutter@76107bd...b12d861 2024-08-10 [email protected] Move windows mokey tests to prod (flutter/flutter#153203) 2024-08-10 [email protected] Roll Flutter Engine from 2f577d8e3fa2 to 3acd373923c9 (7 revisions) (flutter/flutter#153210) 2024-08-09 [email protected] Also run Linux_android_emu tests on API level 34 image (flutter/flutter#153175) 2024-08-09 [email protected] Expose affixes icon constraints in InputDecorationTheme (flutter/flutter#153089) 2024-08-09 [email protected] Spell check range error (flutter/flutter#153055) 2024-08-09 [email protected] Roll Flutter Engine from 4d5b1df96fc9 to 2f577d8e3fa2 (4 revisions) (flutter/flutter#153191) 2024-08-09 [email protected] Roll Flutter Engine from c9ec468c7592 to 4d5b1df96fc9 (6 revisions) (flutter/flutter#153182) 2024-08-09 [email protected] Roll Packages from bb797b9 to f7b1256 (5 revisions) (flutter/flutter#153180) 2024-08-09 [email protected] Move Cupertino focus constants to cupertino/constants.dart (flutter/flutter#153115) 2024-08-09 [email protected] Fix tests expectations regarding new lines. (flutter/flutter#153174) 2024-08-09 [email protected] Shift tests on moto g4 on Windows hosts to mokey in staging (flutter/flutter#153167) 2024-08-09 [email protected] Make ios_deploy_test.dart more robust (flutter/flutter#153147) 2024-08-09 [email protected] Roll Flutter Engine from e50fd307b6f7 to c9ec468c7592 (2 revisions) (flutter/flutter#153145) 2024-08-09 [email protected] Roll Flutter Engine from 05208896830a to e50fd307b6f7 (5 revisions) (flutter/flutter#153143) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
) Manual roll requested by [email protected] flutter/flutter@76107bd...b12d861 2024-08-10 [email protected] Move windows mokey tests to prod (flutter/flutter#153203) 2024-08-10 [email protected] Roll Flutter Engine from 2f577d8e3fa2 to 3acd373923c9 (7 revisions) (flutter/flutter#153210) 2024-08-09 [email protected] Also run Linux_android_emu tests on API level 34 image (flutter/flutter#153175) 2024-08-09 [email protected] Expose affixes icon constraints in InputDecorationTheme (flutter/flutter#153089) 2024-08-09 [email protected] Spell check range error (flutter/flutter#153055) 2024-08-09 [email protected] Roll Flutter Engine from 4d5b1df96fc9 to 2f577d8e3fa2 (4 revisions) (flutter/flutter#153191) 2024-08-09 [email protected] Roll Flutter Engine from c9ec468c7592 to 4d5b1df96fc9 (6 revisions) (flutter/flutter#153182) 2024-08-09 [email protected] Roll Packages from bb797b9 to f7b1256 (5 revisions) (flutter/flutter#153180) 2024-08-09 [email protected] Move Cupertino focus constants to cupertino/constants.dart (flutter/flutter#153115) 2024-08-09 [email protected] Fix tests expectations regarding new lines. (flutter/flutter#153174) 2024-08-09 [email protected] Shift tests on moto g4 on Windows hosts to mokey in staging (flutter/flutter#153167) 2024-08-09 [email protected] Make ios_deploy_test.dart more robust (flutter/flutter#153147) 2024-08-09 [email protected] Roll Flutter Engine from e50fd307b6f7 to c9ec468c7592 (2 revisions) (flutter/flutter#153145) 2024-08-09 [email protected] Roll Flutter Engine from 05208896830a to e50fd307b6f7 (5 revisions) (flutter/flutter#153143) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627
pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
) Manual roll requested by [email protected] flutter/flutter@76107bd...b12d861 2024-08-10 [email protected] Move windows mokey tests to prod (flutter/flutter#153203) 2024-08-10 [email protected] Roll Flutter Engine from 2f577d8e3fa2 to 3acd373923c9 (7 revisions) (flutter/flutter#153210) 2024-08-09 [email protected] Also run Linux_android_emu tests on API level 34 image (flutter/flutter#153175) 2024-08-09 [email protected] Expose affixes icon constraints in InputDecorationTheme (flutter/flutter#153089) 2024-08-09 [email protected] Spell check range error (flutter/flutter#153055) 2024-08-09 [email protected] Roll Flutter Engine from 4d5b1df96fc9 to 2f577d8e3fa2 (4 revisions) (flutter/flutter#153191) 2024-08-09 [email protected] Roll Flutter Engine from c9ec468c7592 to 4d5b1df96fc9 (6 revisions) (flutter/flutter#153182) 2024-08-09 [email protected] Roll Packages from ca14728 to 709205e (5 revisions) (flutter/flutter#153180) 2024-08-09 [email protected] Move Cupertino focus constants to cupertino/constants.dart (flutter/flutter#153115) 2024-08-09 [email protected] Fix tests expectations regarding new lines. (flutter/flutter#153174) 2024-08-09 [email protected] Shift tests on moto g4 on Windows hosts to mokey in staging (flutter/flutter#153167) 2024-08-09 [email protected] Make ios_deploy_test.dart more robust (flutter/flutter#153147) 2024-08-09 [email protected] Roll Flutter Engine from e50fd307b6f7 to c9ec468c7592 (2 revisions) (flutter/flutter#153145) 2024-08-09 [email protected] Roll Flutter Engine from 05208896830a to e50fd307b6f7 (5 revisions) (flutter/flutter#153143) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.