Skip to content

CI builds for windows desktop can fail if Visual Studio installation is incomplete #154453

Open

Description

@christopherfujino

For example: https://ci.chromium.org/ui/p/flutter/builders/try/Windows%20build_tests_1_7/16262/infra

Note:

  1. In step 10, we check if Visual Studio is already installed (https://flutter.googlesource.com/recipes/+/663697664d556d1e8725ac6ab2d53dd972b5145d/recipe_modules/os_utils/api.py#837). We are only looking for the version.
  2. However, the actual output of vswhere.exe has the field "isComplete": false https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8738150602716059217/+/u/VSBuild/Detect_installation/json.output
  3. The tool parses this isComplete field and will fail to build a windows app if it is not complete:
    isComplete: details['isComplete'] as bool?,

Activity

  1. added
    P2Important issues not at the top of the work list
    triaged-infraTriaged by Infrastructure team
    on Aug 30, 2024
  2. christopherfujino commented on Aug 30, 2024

    @christopherfujino
    ContributorAuthor

    A temporary workaround is to teach the recipe to check this field: https://flutter-review.googlesource.com/c/recipes/+/59620

    The long-term solution would be to teach flutter doctor to run specific validators, returning non-zero if they fail, and have CI use this. cc @andrewkolos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listteam-infraOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure team

    Type

    No type

    Projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions