Skip to content

Linux_mokey large_image_changer_perf_android is 6.00% flaky #156945

Closed

Activity

  1. added
    c: flakeTests that sometimes, but not always, incorrectly pass
    P0Critical issues such as a build break or regression
    on Oct 16, 2024
  2. jtmcdole commented on Oct 16, 2024

    @jtmcdole
    Member

    This looks like race conditions with stopping / uninstalling

    [2024-10-13 17:03:25.219495] [STDOUT] stderr: Bad state: StreamSink is closed
    [2024-10-13 17:03:25.219572] [STDOUT] stderr: #0      _StreamSinkImpl.add (dart:_http/http_impl.dart:919:7)
    [2024-10-13 17:03:25.219598] [STDOUT] stderr: #1      _WebSocketImpl.add (dart:_http/websocket_impl.dart:1223:11)
    [2024-10-13 17:03:25.219627] [STDOUT] stderr: #2      VmService._processRequest (package:vm_service/src/vm_service.dart:2030:18)
    [2024-10-13 17:03:25.219662] [STDOUT] stderr: <asynchronous suspension>
    
  3. jtmcdole commented on Oct 16, 2024

    @jtmcdole
    Member

    @andrewkolos - is there another bug tracking this? Maybe this is a driver race condition?

    https://github.com/flutter/flutter/blob/main/dev/benchmarks/macrobenchmarks/test_driver/large_image_changer_test.dart

    [2024-10-11 18:17:16.917150] [STDOUT] stdout: [ +702 ms] executing: /opt/s/w/ir/cache/android/sdk/platform-tools/adb -s NBLZZ5J7HQA67PQO shell dumpsys meminfo com.example.macrobenchmarks -d
    [2024-10-11 18:17:17.000923] [STDOUT] stdout: [  +83 ms] 00:20 �[32m+1�[0m: All tests passed!�[0m
    [2024-10-11 18:17:17.019869] [STDOUT] stdout: [  +18 ms] Unregistering signal handlers...
    [2024-10-11 18:17:17.020744] [STDOUT] stdout: [        ] executing: /opt/s/w/ir/cache/android/sdk/platform-tools/adb -s NBLZZ5J7HQA67PQO shell am force-stop com.example.macrobenchmarks
    [2024-10-11 18:17:17.037860] [STDOUT] stdout: [  +17 ms] I/macrobenchmarks(18487): Explicit concurrent copying GC freed 2786(112KB) AllocSpace objects, 1(20KB) LOS objects, 49% free, 2641KB/5282KB, paused 40us,19us total 10.956ms
    [2024-10-11 18:17:17.101180] [STDOUT] stdout: [  +63 ms] executing: /opt/s/w/ir/cache/android/sdk/platform-tools/adb -s NBLZZ5J7HQA67PQO uninstall com.example.macrobenchmarks
    
  4. andrewkolos commented on Oct 16, 2024

    @andrewkolos
    Contributor

    @andrewkolos - is there another bug tracking this? Maybe this is a driver race condition?

    I am not personally aware of one

  5. jtmcdole commented on Oct 21, 2024

    @jtmcdole
    Member

    There is nothing I can do about this. This hasn't failed in the last 200 runs, so closing: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_mokey%20large_image_changer_perf_android?limit=200

  6. jtmcdole commented on Oct 21, 2024

    @jtmcdole
    Member

    Coming back to this just to dump info: this is clearly a race condition. The memory info (dumpsys meminfo) is not being run directly by the test. I believe it is devtools.

    In both cases all tests pass; but some task in running / logging.

    Good condition:

    [2024-10-13 17:04:07.268241] [STDOUT] stdout: [ +680 ms] 00:20 �[32m+1�[0m: All tests passed!�[0m
    [2024-10-13 17:04:07.284964] [STDOUT] stdout: [  +16 ms] Unregistering signal handlers...
    [2024-10-13 17:04:07.285770] [STDOUT] stdout: [        ] executing: /opt/s/w/ir/cache/android/sdk/platform-tools/adb -s GEAEQCUKXK9LDYIJ shell am force-stop com.example.macrobenchmarks
    [2024-10-13 17:04:07.362239] [STDOUT] stdout: [  +76 ms] executing: /opt/s/w/ir/cache/android/sdk/platform-tools/adb -s GEAEQCUKXK9LDYIJ uninstall com.example.macrobenchmarks
    [2024-10-13 17:04:07.734157] [STDOUT] stdout: [ +371 ms] Success
    [2024-10-13 17:04:07.736759] [STDOUT] stdout: [   +2 ms] "flutter drive" took 40,560ms.
    [2024-10-13 17:04:07.741049] [STDOUT] stdout: [   +4 ms] ensureAnalyticsSent: 0ms
    [2024-10-13 17:04:07.741088] [STDOUT] stdout: [        ] Running 1 shutdown hook
    [2024-10-13 17:04:07.741098] [STDOUT] stdout: [        ] Shutdown hooks complete
    [2024-10-13 17:04:07.741710] [STDOUT] stdout: [        ] exiting with code 0
    

    Race condition:

    [2024-10-13 17:03:24.980311] [STDOUT] stdout: [ +720 ms] executing: /opt/s/w/ir/cache/android/sdk/platform-tools/adb -s GEAEQCUKXK9LDYIJ shell dumpsys meminfo com.example.macrobenchmarks -d
    [2024-10-13 17:03:25.048848] [STDOUT] stdout: [  +68 ms] 00:20 �[32m+1�[0m: All tests passed!�[0m
    [2024-10-13 17:03:25.068380] [STDOUT] stdout: [  +19 ms] Unregistering signal handlers...
    [2024-10-13 17:03:25.069232] [STDOUT] stdout: [        ] executing: /opt/s/w/ir/cache/android/sdk/platform-tools/adb -s GEAEQCUKXK9LDYIJ shell am force-stop com.example.macrobenchmarks
    [2024-10-13 17:03:25.094322] [STDOUT] stdout: [  +24 ms] I/macrobenchmarks(29229): Explicit concurrent copying GC freed 2786(112KB) AllocSpace objects, 1(20KB) LOS objects, 49% free, 2640KB/5281KB, paused 33us,26us total 9.978ms
    [2024-10-13 17:03:25.153333] [STDOUT] stdout: [  +59 ms] executing: /opt/s/w/ir/cache/android/sdk/platform-tools/adb -s GEAEQCUKXK9LDYIJ uninstall com.example.macrobenchmarks
    [2024-10-13 17:03:25.212468] [STDOUT] stdout: [  +58 ms] Applications Memory Usage (in Kilobytes):
    [2024-10-13 17:03:25.212536] [STDOUT] stdout:            Uptime: 93836898 Realtime: 93836898
    [2024-10-13 17:03:25.212596] [STDOUT] stdout: 
    [2024-10-13 17:03:25.212614] [STDOUT] stdout:            ** MEMINFO in pid 29229 [com.example.macrobenchmarks] **
    [2024-10-13 17:03:25.219454] [STDOUT] stderr: 
    [2024-10-13 17:03:25.219495] [STDOUT] stderr: Bad state: StreamSink is closed
    [2024-10-13 17:03:25.219572] [STDOUT] stderr: #0      _StreamSinkImpl.add (dart:_http/http_impl.dart:919:7)
    [2024-10-13 17:03:25.219598] [STDOUT] stderr: #1      _WebSocketImpl.add (dart:_http/websocket_impl.dart:1223:11)
    [2024-10-13 17:03:25.219627] [STDOUT] stderr: #2      VmService._processRequest (package:vm_service/src/vm_service.dart:2030:18)
    [2024-10-13 17:03:25.219662] [STDOUT] stderr: <asynchronous suspension>
    [2024-10-13 17:03:25.219687] [STDOUT] stderr: 
    [2024-10-13 17:03:25.221742] [STDOUT] stdout: [   +9 ms] ensureAnalyticsSent: 0ms
    [2024-10-13 17:03:25.221781] [STDOUT] stdout: [        ] Running 1 shutdown hook
    [2024-10-13 17:03:25.221963] [STDOUT] stdout: [        ] Shutdown hooks complete
    [2024-10-13 17:03:25.222270] [STDOUT] stdout: [        ] exiting with code 1
    [2024-10-13 17:03:25.237679] [STDERR] Task failed: Executable "/opt/s/w/ir/x/w/rc/tmps6rlcof_/flutter sdk/bin/flutter" failed with exit code 1.
    [2024-10-13 17:03:25.237765] [STDERR] 
    [2024-10-13 17:03:25.237780] [STDERR] Stack trace:
    [2024-10-13 17:03:25.249813] [STDERR] package:flutter_devicelab/framework/utils.dart 110:3       fail
    [2024-10-13 17:03:25.249844] [STDERR] package:flutter_devicelab/framework/utils.dart 383:5       _execute
    [2024-10-13 17:03:25.249852] [STDERR] ===== asynchronous gap ===========================
    [2024-10-13 17:03:25.249856] [STDERR] dart:async                                                 _CustomZone.registerBinaryCallback
    [2024-10-13 17:03:25.249863] [STDERR] package:flutter_devicelab/framework/framework.dart 299:26  _TaskRunner._performTask.<fn>
    [2024-10-13 17:03:25.249869] [STDERR] package:stack_trace                                        Chain.capture
    [2024-10-13 17:03:25.249873] [STDERR] package:flutter_devicelab/framework/framework.dart 298:11  _TaskRunner._performTask
    [2024-10-13 17:03:25.249879] [STDERR] package:flutter_devicelab/framework/framework.dart 191:43  _TaskRunner.run
    [2024-10-13 17:03:25.249884] [STDERR] 
    [2024-10-13 17:03:25.252282] [STDOUT] Checking for reboot
    [large_image_changer_perf_android] Process terminated with exit code 0.
    
  7. github-actions commented on Nov 4, 2024

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  8. locked as resolved and limited conversation to collaborators on Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P0Critical issues such as a build break or regressionc: flakeTests that sometimes, but not always, incorrectly passteam-engineOwned by Engine team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions