Skip to content

Make BoxDecoration extensible #160

Description

@FlutterIssues

Issue by Hixie
Monday Sep 14, 2015 at 16:32 GMT
Originally opened as https://github.com/flutter/engine/issues/1156


We should have BoxDecoration inherit from a superclass that has a "get painter" method that returns an object that does the painting, and BoxDecoration overrides that method to return a BoxPainter constructed with a copy of the BoxDecoration in question.

Activity

  1. added this to the milestone on Nov 9, 2015
  2. added
    frameworkflutter/packages/flutter repository. See also f: labels.
    c: new featureNothing broken; request for a new capability
    on Nov 9, 2015
  3. abarth commented on Dec 5, 2015

    @abarth
    Contributor

    Do we still want this given that we now have CustomPaint? I'm not sure when I'd use this instead of either CustomPaint or just make new MyDecoratedBox / MyBoxDecoration.

  4. Hixie commented on Dec 7, 2015

    @Hixie
    Contributor

    I'm not sure. I tried implementing it; see the example at the top of the diff: #781

    I agree that it's weird to have two ways to do this. Maybe Container should use a CustomPaint instead of RenderDecoratedBox?

  5. abarth commented on Feb 1, 2016

    @abarth
    Contributor

    @Hixie did this.

  6. github-actions commented on Aug 17, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  7. locked as resolved and limited conversation to collaborators on Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    c: new featureNothing broken; request for a new capabilityframeworkflutter/packages/flutter repository. See also f: labels.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions