Repository navigation
Make BoxDecoration extensible #160
Description
Monday Sep 14, 2015 at 16:32 GMT
Originally opened as https://github.com/flutter/engine/issues/1156
We should have BoxDecoration inherit from a superclass that has a "get painter" method that returns an object that does the painting, and BoxDecoration overrides that method to return a BoxPainter constructed with a copy of the BoxDecoration in question.
Activity
abarth commentedon Dec 5, 2015
Do we still want this given that we now have CustomPaint? I'm not sure when I'd use this instead of either CustomPaint or just make new MyDecoratedBox / MyBoxDecoration.
Hixie commentedon Dec 7, 2015
I'm not sure. I tried implementing it; see the example at the top of the diff: #781
I agree that it's weird to have two ways to do this. Maybe Container should use a CustomPaint instead of RenderDecoratedBox?
abarth commentedon Feb 1, 2016
@Hixie did this.
Revert "Remove explicit whitelists for GN check. All our targets pass…
github-actions commentedon Aug 17, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.