Update engine_hash.{dart|sh} #160527

Activity

1. matanlurey

   added

   team-infraOwned by Infrastructure teamOwned by Infrastructure team

   P1High-priority issues at the top of the work listHigh-priority issues at the top of the work list

   monorepo

   on Dec 18, 2024
2. matanlurey

   self-assigned this

   on Dec 18, 2024
3. github-project-automation

   added this to [DEPRECATED] Infra Ticket Queueon Dec 18, 2024
4. github-project-automation

   moved this to New in [DEPRECATED] Infra Ticket Queueon Dec 18, 2024
5. christopherfujino

   added

   triaged-infraTriaged by Infrastructure teamTriaged by Infrastructure team

   on Dec 18, 2024
6. matanlurey commented on Dec 18, 2024

   

   matanlurey

   on Dec 18, 2024

   ContributorAuthor

   More actions

   I'm confused on what exactly needs to change (and why) - the Dart script in particular seems unused (outside of its own test), and the Shell script, used in google3, I'm not sure why that needs realm logic or what exactly should be done here :)

   Asked @jtmcdole for clarification.
7. matanlurey commented on Dec 18, 2024

   

   matanlurey

   on Dec 18, 2024

   Last edited by matanlurey

   ContributorAuthor

   More actions

   @jtmcdole it should return:

   if [ -f "$FLUTTER_ROOT/DEPS" ] && [ -f "$FLUTTER_ROOT/engine/src/.gn" ]; then
     BRANCH=$(git -C "$FLUTTER_ROOT" rev-parse --abbrev-ref HEAD)
     # In a fusion repository; the engine.version comes from the git hashes.
     if [ -z "${LUCI_CONTEXT}" ]; then
       ENGINE_VERSION=$(git -C "$FLUTTER_ROOT" merge-base HEAD upstream/master)
     else
       ENGINE_VERSION=$(git -C "$FLUTTER_ROOT" rev-parse HEAD)
     fi

   I think they'll just need rev-pasrse HEAD
   because they are taking it from master already
8. github-merge-queue

   added a commit that references this issue on Dec 23, 2024

   Delete unused `engine_hash.dart` script (and test), simplify `engine_…

   ...

   62c6859
9. auto-submit

   closed this as completedin #160549on Dec 23, 2024
10. github-project-automation

    moved this from New to Fixed in [DEPRECATED] Infra Ticket Queueon Dec 23, 2024
11. github-actions commented on Jan 6, 2025

    

    github-actionsbot

    on Jan 6, 2025 – with GitHub Actions

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
12. github-actions

    locked as resolved and limited conversation to collaborators on Jan 6, 2025