Skip to content

[CP] Fix TabBar glitchy elastic Tab animation #161664

Closed

Description

@TahaTesser

Issue Link

#160631

Target

stable

Cherry pick PR Link

#161514

Changelog Description

Fix TabBar glitchy elastic Tab animation

Impacted Users

Apps using the TabBar widget

Impact Description

Visual animation glitches

Before the fix

before.mp4

After the fix

fixed.mp4

Workaround

Modify default Tab animation which defaults to TabIndicatorAnimation.elastic. This default Tab animation glitches on 3.27.x releases.

Set TabBar.indicatorAnimation parameter to TabIndicatorAnimation.linear as a workaround.

Risk

low

Test Coverage

yes

Validation Steps

No response

Activity

  1. TahaTesser commented on Jan 15, 2025

    @TahaTesser
    ContributorAuthor
  2. eyebrowsoffire commented on Jan 16, 2025

    @eyebrowsoffire
    Contributor

    I ported over the request to the stable branch here: #161783

  3. Igos19 commented on Jan 23, 2025

    @Igos19

    This is example from https://docs.flutter.dev/cookbook/design/tabs but added two more tabs. Pay attention on the last tab, it is blinking.

    Screen.Recording.2025-01-23.at.21.57.31.mov
  4. eyebrowsoffire commented on Jan 23, 2025

    @eyebrowsoffire
    Contributor

    This was merged into 3.27.3

  5. Igos19 commented on Jan 23, 2025

    @Igos19

    It is reproduced on 3.27.3 (Same buggy behavior in my app built with 3.27.3)

  6. eyebrowsoffire commented on Jan 23, 2025

    @eyebrowsoffire
    Contributor

    @Igos19 Are you saying you have different behavior between 3.27.3 and the master branch (which would indicate something went wrong with the cherry-pick)? If the behavior is the same (but still wrong) on both 3.27.3 and the master branch, could you file a separate issue for that? This issue is just for the cherry-pick of the existing fix from the master branch to stable. If an additional fix is needed, we will need to investigate and track that in a different issue.

  7. TahaTesser commented on Jan 23, 2025

    @TahaTesser
    ContributorAuthor

    It is reproduced on 3.27.3 (Same buggy behavior in my app built with 3.27.3)

    Dartpad preview might not be using 3.27.3. Could please test it locally?

  8. TahaTesser commented on Jan 23, 2025

    @TahaTesser
    ContributorAuthor

    If this issue is reproducible locally on 3.27.3, please file a new issue as mentioned above and tag me in that issue. We added a bunch of new type of tests to catch unexpected behavior with this animation

  9. github-actions commented on Feb 6, 2025

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  10. locked as resolved and limited conversation to collaborators on Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

cp: reviewCherry-picks in the review queue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions