Repository navigation
IconButton.styleFrom is missing iconColor property #163126
Description
Steps to reproduce
More details in this thread.
#162880 (comment)
This works as expected
However, we can't define iconColor in the button style class using IconButton.styleFrom. IconButton.styleFrom is missing iconColor property.
https://api.flutter.dev/flutter/material/IconButton/styleFrom.html
Expected results
IconButton icon color should be customizable using ButtonStyle.iconColor as well as using IconButton.styleFrom
IconButton.styleFrom is missing iconColor property
https://api.flutter.dev/flutter/material/IconButton/styleFrom.html
Actual results
Cannot override iconColor using IconButton.styleFrom.
Code sample
Code sample
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: Scaffold(
body: Center(
child: IconButtonTheme(
data: const IconButtonThemeData(
style: ButtonStyle(
iconColor: WidgetStatePropertyAll<Color>(Colors.red),
),
// ),
// data: IconButton.styleFrom(
// iconColor:
),
child: IconButton(
onPressed: () {},
icon: const Icon(Icons.ac_unit),
),
),
),
),
);
}
}
Screenshots or Video
Screenshots / Video demonstration
[Upload media here]
Logs
Logs
[Paste your logs here]Flutter Doctor output
Doctor output
[Paste your output here]
Activity
[-]`IconButton` only supports `ButtonStyle.iconColor` since `IconButton.styleFrom` doesn't have the `iconColor property[/-][+]`IconButton` only supports `ButtonStyle.iconColor` since `IconButton.styleFrom` doesn't have the `iconColor` property[/+][-]`IconButton` only supports `ButtonStyle.iconColor` since `IconButton.styleFrom` doesn't have the `iconColor` property[/-][+]`IconButton.styleFrom` is missing `iconColor property[/+][-]`IconButton.styleFrom` is missing `iconColor property[/-][+]`IconButton.styleFrom` is missing `iconColor` property[/+]TahaTesser commentedon Feb 12, 2025
Is it worth adding
iconColortoIconButton.styleFromor should we ignore it forIconButtonas it'd typically only have icon? @rydmike @QuncCcccccrydmike commentedon Feb 12, 2025
As long as the icon gets the correct color when using
IconButton.styleFrom.foregroundColorthat is fine imo. No need to pollute and confuse this convenience API with an extraiconColorwhen there is only one part to color in theIconButton, especially since foreground color already also has thedisabledForegroundColorhelper.I was just concerned about what the behavior is when you use raw
ButtonStyleon anIconButtonand provide justforegroundColororiconColor, or both, that all three cases work and that it also then has the right fallback priority viaforegroundColorand theniconColor.Sounds and looks like that part is covered and works OK.
TahaTesser commentedon Feb 12, 2025
Sounds good to me!
github-actions commentedon Feb 26, 2025
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.